๐ :: (#61) SignInPage ํผ๋ธ๋ฆฌ์ฑ ํ์ต๋๋ค. #62
Conversation
Walkthrough์ด๋ฒ PR์์๋ ์ค์ ํ์ผ๊ณผ ๋น๋ ๊ด๋ จ ํ์ผ์ ๊ฐ์ํ ์์
๊ณผ ํจ๊ป, ์ฌ์ฉ์ ๋ก๊ทธ์ธ UI๋ฅผ ์ํ ์๋ก์ด Jetpack Compose ๊ธฐ๋ฐ ์ปดํฌ๋ํธ๋ค์ ์ถ๊ฐํ์์ต๋๋ค. XML ๊ตฌ์ฑ ํ์ผ์์๋ ๋ถํ์ํ Changes
Suggested labels
Poem
โจ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? ๐ชง TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
๐งน Nitpick comments (3)
presentation/src/main/java/view/signin/component/DoMaLoginButton.kt (1)
31-31: ์์ ๊ฐ์ ํ ๋ง๋ก ์ด๋ํ๋ ๊ฒ์ด ์ข์ต๋๋ค.ํ๋์ฝ๋ฉ๋ ์์ ๊ฐ์ ํ ๋ง ์์คํ ์ผ๋ก ์ด๋ํ์ฌ ์ผ๊ด์ฑ ์๋ ๋์์ธ์ ์ ์งํ๋ ๊ฒ์ด ์ข์ต๋๋ค.
- .background(color = Color(0xFF494949), shape = RoundedCornerShape(size = 10.dp)) + .background(color = DoMaTheme.colors.buttonBackground, shape = RoundedCornerShape(size = 10.dp))presentation/src/main/java/view/signin/screen/SignInScreen.kt (2)
26-96: ์์ ๊ด๋ฆฌ์ ์ฝ๋ ์ฌ์ฌ์ฉ์ฑ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.
- ํ๋์ฝ๋ฉ๋ ์์๊ฐ๋ค์ ํ ๋ง ํ์ผ๋ก ์ด๋ํ์ฌ ์ค์ ๊ด๋ฆฌ๊ฐ ํ์ํฉ๋๋ค.
- ์ ์ฌํ ์คํ์ผ์ Text ์ปดํฌ๋ํธ๋ค์ ์ฌ์ฌ์ฉ ๊ฐ๋ฅํ ์ปดํฌ๋ํธ๋ก ์ถ์ถํ๋ฉด ์ข๊ฒ ์ต๋๋ค.
์์๊ฐ์ ํ ๋ง๋ก ์ด๋ํ๊ณ ๊ณตํต ํ ์คํธ ์ปดํฌ๋ํธ๋ฅผ ๋ง๋๋ ๊ฒ์ ์ ์ํฉ๋๋ค:
+// Colors.kt +val DarkBackground = Color(0xFF1E1E1E) +val PrimaryGreen = Color(0xFF9BFFA6) +val TextWhite = Color(0xFFFFFFFF) +val TextLightGray = Color(0xFFFAFAFA) +// CommonText.kt +@Composable +fun DoMaText( + text: String, + style: TextStyle = DoMaTypography.labelLarge, + color: Color = TextLightGray, + textAlign: TextAlign = TextAlign.Start +) { + Text( + text = text, + style = style.copy(color = color), + textAlign = textAlign + ) +}
109-117: ํ๋ฆฌ๋ทฐ ํจ์ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.
- ๋ ์๋ฏธ ์๋ ํ๋ฆฌ๋ทฐ๋ฅผ ์ํด mock ๊ตฌํ์ด ํ์ํฉ๋๋ค.
- ๋ค์ํ ํ ๋ง์ ์ํ์ ๋ํ ํ๋ฆฌ๋ทฐ๊ฐ ์์ผ๋ฉด ์ข๊ฒ ์ต๋๋ค.
๋ค์๊ณผ ๊ฐ์ ํ๋ฆฌ๋ทฐ ๊ตฌ์ฑ์ ์ ์ํฉ๋๋ค:
+@Preview(name = "Light Theme") @Preview(name = "Dark Theme", uiMode = UI_MODE_NIGHT_YES) @Composable -fun PreviewSignInScreen() { +fun PreviewSignInScreen() { + val mockGAuthLogin: (String) -> Unit = { code -> + println("Auth code received: $code") + } + + val mockLoginClick: () -> Unit = { + println("Login button clicked") + } + SignInScreen( - ClickButton = false, - gAuthLogin = {}, - leIsClickLoginButton = {} + clickButton = false, + gAuthLogin = mockGAuthLogin, + leIsClickLoginButton = mockLoginClick ) }
๐ Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
โ Files ignored due to path filters (3)
buildSrc/build/kotlin/compileKotlin/cacheable/last-build.binis excluded by!**/*.binbuildSrc/build/kotlin/compileKotlin/local-state/build-history.binis excluded by!**/*.binbuildSrc/build/libs/buildSrc.jaris excluded by!**/*.jar
๐ Files selected for processing (7)
.idea/deploymentTargetSelector.xml(0 hunks)buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/counters.tab(1 hunks)presentation/src/main/java/view/signin/component/DoMaInputID.kt(1 hunks)presentation/src/main/java/view/signin/component/DoMaInputPassword.kt(1 hunks)presentation/src/main/java/view/signin/component/DoMaLoginButton.kt(1 hunks)presentation/src/main/java/view/signin/screen/SignInScreen.kt(1 hunks)presentation/src/main/java/view/signin/screen/SignInSubScreen.kt(1 hunks)
๐ค Files with no reviewable changes (1)
- .idea/deploymentTargetSelector.xml
โ Files skipped from review due to trivial changes (1)
- buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/counters.tab
โฐ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
| fun DoMaLoginButton( | ||
| modifier: Modifier = Modifier, | ||
| onClick: () -> Unit, | ||
| ) { | ||
| Row( | ||
| horizontalArrangement = Arrangement.spacedBy(10.dp, Alignment.CenterHorizontally), | ||
| verticalAlignment = Alignment.CenterVertically, | ||
| modifier = modifier | ||
| .fillMaxWidth() | ||
| .clickablesingle(onClick = onClick) | ||
| .background(color = Color(0xFF494949), shape = RoundedCornerShape(size = 10.dp)) | ||
| .padding( | ||
| horizontal = 16.dp, | ||
| vertical = 12.dp, | ||
| ), | ||
|
|
||
| ) { | ||
| Text( | ||
| text = "๋ก๊ทธ์ธ", | ||
| style = TextStyle( | ||
| fontSize = 16.sp, | ||
| fontWeight = FontWeight(700), | ||
| color = Color(0xFFE0E0E0), | ||
| ) | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
๐ ๏ธ Refactor suggestion
๋ก๋ฉ ์ํ ๋ฐ ์ ๊ทผ์ฑ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.
- ๋ก๋ฉ ์ํ๋ฅผ ์ถ๊ฐํ์ฌ ์ฌ์ฉ์์๊ฒ ํผ๋๋ฐฑ์ ์ ๊ณตํด์ผ ํฉ๋๋ค.
- ์ ๊ทผ์ฑ์ ์ํ contentDescription์ ์ถ๊ฐํด์ผ ํฉ๋๋ค.
fun DoMaLoginButton(
modifier: Modifier = Modifier,
+ isLoading: Boolean = false,
onClick: () -> Unit,
) {
Row(
horizontalArrangement = Arrangement.spacedBy(10.dp, Alignment.CenterHorizontally),
verticalAlignment = Alignment.CenterVertically,
modifier = modifier
.fillMaxWidth()
.clickablesingle(onClick = onClick)
.background(color = Color(0xFF494949), shape = RoundedCornerShape(size = 10.dp))
+ .semantics { contentDescription = "๋ก๊ทธ์ธ ๋ฒํผ" }
.padding(
horizontal = 16.dp,
vertical = 12.dp,
),
) {
+ if (isLoading) {
+ CircularProgressIndicator(
+ color = Color(0xFFE0E0E0),
+ modifier = Modifier.size(16.dp)
+ )
+ } else {
Text(
text = "๋ก๊ทธ์ธ",
style = TextStyle(
fontSize = 16.sp,
fontWeight = FontWeight(700),
color = Color(0xFFE0E0E0),
)
)
+ }
}
}๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| fun DoMaLoginButton( | |
| modifier: Modifier = Modifier, | |
| onClick: () -> Unit, | |
| ) { | |
| Row( | |
| horizontalArrangement = Arrangement.spacedBy(10.dp, Alignment.CenterHorizontally), | |
| verticalAlignment = Alignment.CenterVertically, | |
| modifier = modifier | |
| .fillMaxWidth() | |
| .clickablesingle(onClick = onClick) | |
| .background(color = Color(0xFF494949), shape = RoundedCornerShape(size = 10.dp)) | |
| .padding( | |
| horizontal = 16.dp, | |
| vertical = 12.dp, | |
| ), | |
| ) { | |
| Text( | |
| text = "๋ก๊ทธ์ธ", | |
| style = TextStyle( | |
| fontSize = 16.sp, | |
| fontWeight = FontWeight(700), | |
| color = Color(0xFFE0E0E0), | |
| ) | |
| ) | |
| } | |
| } | |
| fun DoMaLoginButton( | |
| modifier: Modifier = Modifier, | |
| isLoading: Boolean = false, | |
| onClick: () -> Unit, | |
| ) { | |
| Row( | |
| horizontalArrangement = Arrangement.spacedBy(10.dp, Alignment.CenterHorizontally), | |
| verticalAlignment = Alignment.CenterVertically, | |
| modifier = modifier | |
| .fillMaxWidth() | |
| .clickablesingle(onClick = onClick) | |
| .background(color = Color(0xFF494949), shape = RoundedCornerShape(size = 10.dp)) | |
| .semantics { contentDescription = "๋ก๊ทธ์ธ ๋ฒํผ" } | |
| .padding( | |
| horizontal = 16.dp, | |
| vertical = 12.dp, | |
| ), | |
| ) { | |
| if (isLoading) { | |
| CircularProgressIndicator( | |
| color = Color(0xFFE0E0E0), | |
| modifier = Modifier.size(16.dp) | |
| ) | |
| } else { | |
| Text( | |
| text = "๋ก๊ทธ์ธ", | |
| style = TextStyle( | |
| fontSize = 16.sp, | |
| fontWeight = FontWeight(700), | |
| color = Color(0xFFE0E0E0), | |
| ) | |
| ) | |
| } | |
| } | |
| } |
| fun DoMaInputID( | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| val idState = remember { mutableStateOf(TextFieldValue("")) } // viewmodel ๊ตฌํ ํ ์์ ํ๊ฒ ์ต๋๋ค. |
There was a problem hiding this comment.
๐ ๏ธ Refactor suggestion
์ํ ๊ด๋ฆฌ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.
ViewModel ๊ตฌํ ์ ์ด๋ผ๋ ์ํ๋ฅผ ์์ ์ปดํฌ๋ํธ๋ก ํธ์ด์คํ ํ์ฌ ๊ด๋ฆฌํ๋ ๊ฒ์ด ์ข์ต๋๋ค.
fun DoMaInputID(
modifier: Modifier = Modifier,
+ value: TextFieldValue,
+ onValueChange: (TextFieldValue) -> Unit,
) {
- val idState = remember { mutableStateOf(TextFieldValue("")) }๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| val idState = remember { mutableStateOf(TextFieldValue("")) } // viewmodel ๊ตฌํ ํ ์์ ํ๊ฒ ์ต๋๋ค. | |
| fun DoMaInputID( | |
| modifier: Modifier = Modifier, | |
| value: TextFieldValue, | |
| onValueChange: (TextFieldValue) -> Unit, | |
| ) { | |
| // Removed internal state management and use the hoisted state instead. | |
| // val idState = remember { mutableStateOf(TextFieldValue("")) } | |
| // Implementation code that utilizes 'value' and 'onValueChange' should follow. | |
| } |
| OutlinedTextField( | ||
| modifier = Modifier.fillMaxWidth(), | ||
| value = idState.value, | ||
| onValueChange = { idState.value = it }, | ||
| textStyle = DoMaTypography.labelLarge.copy(color = Color.White), | ||
| shape = RoundedCornerShape(12.dp), | ||
| singleLine = true, | ||
| placeholder = { | ||
| Text( | ||
| text = "์์ด๋๋ฅผ ์ ๋ ฅํด์ฃผ์ธ์.", | ||
| style = DoMaTypography.labelLarge.copy(color = Color(0xFF989898)) | ||
| ) | ||
| }, | ||
| colors = TextFieldDefaults.outlinedTextFieldColors( | ||
| backgroundColor = Color(0xFF1E1E1E), | ||
| cursorColor = Color.White, | ||
| focusedBorderColor = Color(0xFFB9B9B9), | ||
| unfocusedBorderColor = Color(0xFFB9B9B9) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
์ ๋ ฅ ์ ํจ์ฑ ๊ฒ์ฌ ๋ฐ ๋ณด์ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.
- ID ์ ๋ ฅ ์ ํ ๋ฐ ์ ํจ์ฑ ๊ฒ์ฌ๊ฐ ํ์ํฉ๋๋ค.
- ์ ๋ ฅ๊ฐ ํํฐ๋ง์ ํตํ ๋ณด์ ๊ฐํ๊ฐ ํ์ํฉ๋๋ค.
OutlinedTextField(
modifier = Modifier.fillMaxWidth(),
- value = idState.value,
- onValueChange = { idState.value = it },
+ value = value,
+ onValueChange = { newValue ->
+ // ID ๊ธธ์ด ์ ํ
+ if (newValue.text.length <= 20) {
+ // ํน์๋ฌธ์ ํํฐ๋ง
+ val filteredText = newValue.text.filter { it.isLetterOrDigit() || it == '_' }
+ onValueChange(TextFieldValue(
+ text = filteredText,
+ selection = TextRange(filteredText.length)
+ ))
+ }
+ },
textStyle = DoMaTypography.labelLarge.copy(color = Color.White),
shape = RoundedCornerShape(12.dp),
singleLine = true,
+ isError = !isValidId(value.text),
placeholder = {๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| OutlinedTextField( | |
| modifier = Modifier.fillMaxWidth(), | |
| value = idState.value, | |
| onValueChange = { idState.value = it }, | |
| textStyle = DoMaTypography.labelLarge.copy(color = Color.White), | |
| shape = RoundedCornerShape(12.dp), | |
| singleLine = true, | |
| placeholder = { | |
| Text( | |
| text = "์์ด๋๋ฅผ ์ ๋ ฅํด์ฃผ์ธ์.", | |
| style = DoMaTypography.labelLarge.copy(color = Color(0xFF989898)) | |
| ) | |
| }, | |
| colors = TextFieldDefaults.outlinedTextFieldColors( | |
| backgroundColor = Color(0xFF1E1E1E), | |
| cursorColor = Color.White, | |
| focusedBorderColor = Color(0xFFB9B9B9), | |
| unfocusedBorderColor = Color(0xFFB9B9B9) | |
| ) | |
| ) | |
| OutlinedTextField( | |
| modifier = Modifier.fillMaxWidth(), | |
| value = value, | |
| onValueChange = { newValue -> | |
| // ID ๊ธธ์ด ์ ํ | |
| if (newValue.text.length <= 20) { | |
| // ํน์๋ฌธ์ ํํฐ๋ง | |
| val filteredText = newValue.text.filter { it.isLetterOrDigit() || it == '_' } | |
| onValueChange( | |
| TextFieldValue( | |
| text = filteredText, | |
| selection = TextRange(filteredText.length) | |
| ) | |
| ) | |
| } | |
| }, | |
| textStyle = DoMaTypography.labelLarge.copy(color = Color.White), | |
| shape = RoundedCornerShape(12.dp), | |
| singleLine = true, | |
| isError = !isValidId(value.text), | |
| placeholder = { | |
| Text( | |
| text = "์์ด๋๋ฅผ ์ ๋ ฅํด์ฃผ์ธ์.", | |
| style = DoMaTypography.labelLarge.copy(color = Color(0xFF989898)) | |
| ) | |
| }, | |
| colors = TextFieldDefaults.outlinedTextFieldColors( | |
| backgroundColor = Color(0xFF1E1E1E), | |
| cursorColor = Color.White, | |
| focusedBorderColor = Color(0xFFB9B9B9), | |
| unfocusedBorderColor = Color(0xFFB9B9B9) | |
| ) | |
| ) |
| val idState = remember { mutableStateOf(TextFieldValue("")) } // viewmodel ๊ตฌํ ํ ์์ ํ๊ฒ ์ต๋๋ค. | ||
|
|
||
| Column( | ||
| modifier = Modifier | ||
| ) { | ||
| Text( | ||
| text = "๋น๋ฐ๋ฒํธ", | ||
| style = DoMaTypography.bodyMedium.copy(color = Color(0xFFFAFAFA)) | ||
| ) | ||
| Spacer( | ||
| modifier = Modifier.height(4.dp) | ||
| ) | ||
| OutlinedTextField( | ||
| modifier = Modifier.fillMaxWidth(), | ||
| value = idState.value, | ||
| onValueChange = { idState.value = it }, | ||
| textStyle = DoMaTypography.labelLarge.copy(color = Color.White), | ||
| shape = RoundedCornerShape(12.dp), | ||
| singleLine = true, | ||
| placeholder = { | ||
| Text( | ||
| text = "๋น๋ฐ๋ฒํธ๋ฅผ ์ ๋ ฅํด์ฃผ์ธ์.", | ||
| style = DoMaTypography.labelLarge.copy(color = Color(0xFF989898)) | ||
| ) | ||
| }, | ||
| colors = TextFieldDefaults.outlinedTextFieldColors( | ||
| backgroundColor = Color(0xFF1E1E1E), | ||
| cursorColor = Color.White, | ||
| focusedBorderColor = Color(0xFFB9B9B9), | ||
| unfocusedBorderColor = Color(0xFFB9B9B9) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
๋น๋ฐ๋ฒํธ ์ ๋ ฅ ํ๋์ ๋ณด์ ๋ฐ UX ๊ฐ์ ์ด ํ์ํฉ๋๋ค.
- ๋น๋ฐ๋ฒํธ ํ์/์จ๊น ํ ๊ธ์ด ํ์ํฉ๋๋ค.
- ๋น๋ฐ๋ฒํธ ์๊ตฌ์ฌํญ ํ์๊ฐ ํ์ํฉ๋๋ค.
- ๋น๋ฐ๋ฒํธ ์ ๋ ฅ ์ ๋ง์คํน์ด ํ์ํฉ๋๋ค.
+import androidx.compose.material.IconButton
+import androidx.compose.material.icons.Icons
+import androidx.compose.material.icons.filled.Visibility
+import androidx.compose.material.icons.filled.VisibilityOff
+import androidx.compose.ui.text.input.PasswordVisualTransformation
+import androidx.compose.ui.text.input.VisualTransformation
fun DoMaInputPassword(
modifier: Modifier = Modifier,
+ value: TextFieldValue,
+ onValueChange: (TextFieldValue) -> Unit,
) {
- val idState = remember { mutableStateOf(TextFieldValue("")) }
+ var passwordVisible by remember { mutableStateOf(false) }
Column(
modifier = Modifier
) {
Text(
text = "๋น๋ฐ๋ฒํธ",
style = DoMaTypography.bodyMedium.copy(color = Color(0xFFFAFAFA))
)
+ Text(
+ text = "8์ ์ด์, ์๋ฌธ/์ซ์/ํน์๋ฌธ์ ์กฐํฉ",
+ style = DoMaTypography.caption.copy(color = Color(0xFF989898))
+ )
Spacer(
modifier = Modifier.height(4.dp)
)
OutlinedTextField(
modifier = Modifier.fillMaxWidth(),
- value = idState.value,
- onValueChange = { idState.value = it },
+ value = value,
+ onValueChange = onValueChange,
textStyle = DoMaTypography.labelLarge.copy(color = Color.White),
shape = RoundedCornerShape(12.dp),
singleLine = true,
+ visualTransformation = if (passwordVisible)
+ VisualTransformation.None
+ else
+ PasswordVisualTransformation(),
+ trailingIcon = {
+ IconButton(onClick = { passwordVisible = !passwordVisible }) {
+ Icon(
+ imageVector = if (passwordVisible)
+ Icons.Filled.Visibility
+ else
+ Icons.Filled.VisibilityOff,
+ contentDescription = if (passwordVisible)
+ "๋น๋ฐ๋ฒํธ ์จ๊ธฐ๊ธฐ"
+ else
+ "๋น๋ฐ๋ฒํธ ํ์"
+ )
+ }
+ },๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| val idState = remember { mutableStateOf(TextFieldValue("")) } // viewmodel ๊ตฌํ ํ ์์ ํ๊ฒ ์ต๋๋ค. | |
| Column( | |
| modifier = Modifier | |
| ) { | |
| Text( | |
| text = "๋น๋ฐ๋ฒํธ", | |
| style = DoMaTypography.bodyMedium.copy(color = Color(0xFFFAFAFA)) | |
| ) | |
| Spacer( | |
| modifier = Modifier.height(4.dp) | |
| ) | |
| OutlinedTextField( | |
| modifier = Modifier.fillMaxWidth(), | |
| value = idState.value, | |
| onValueChange = { idState.value = it }, | |
| textStyle = DoMaTypography.labelLarge.copy(color = Color.White), | |
| shape = RoundedCornerShape(12.dp), | |
| singleLine = true, | |
| placeholder = { | |
| Text( | |
| text = "๋น๋ฐ๋ฒํธ๋ฅผ ์ ๋ ฅํด์ฃผ์ธ์.", | |
| style = DoMaTypography.labelLarge.copy(color = Color(0xFF989898)) | |
| ) | |
| }, | |
| colors = TextFieldDefaults.outlinedTextFieldColors( | |
| backgroundColor = Color(0xFF1E1E1E), | |
| cursorColor = Color.White, | |
| focusedBorderColor = Color(0xFFB9B9B9), | |
| unfocusedBorderColor = Color(0xFFB9B9B9) | |
| ) | |
| ) | |
| import androidx.compose.material.IconButton | |
| import androidx.compose.material.icons.Icons | |
| import androidx.compose.material.icons.filled.Visibility | |
| import androidx.compose.material.icons.filled.VisibilityOff | |
| import androidx.compose.material.TextFieldDefaults | |
| import androidx.compose.runtime.getValue | |
| import androidx.compose.runtime.mutableStateOf | |
| import androidx.compose.runtime.remember | |
| import androidx.compose.runtime.setValue | |
| import androidx.compose.ui.text.input.PasswordVisualTransformation | |
| import androidx.compose.ui.text.input.TextFieldValue | |
| import androidx.compose.ui.text.input.VisualTransformation | |
| fun DoMaInputPassword( | |
| modifier: Modifier = Modifier, | |
| value: TextFieldValue, | |
| onValueChange: (TextFieldValue) -> Unit, | |
| ) { | |
| var passwordVisible by remember { mutableStateOf(false) } | |
| Column( | |
| modifier = Modifier | |
| ) { | |
| Text( | |
| text = "๋น๋ฐ๋ฒํธ", | |
| style = DoMaTypography.bodyMedium.copy(color = Color(0xFFFAFAFA)) | |
| ) | |
| Text( | |
| text = "8์ ์ด์, ์๋ฌธ/์ซ์/ํน์๋ฌธ์ ์กฐํฉ", | |
| style = DoMaTypography.caption.copy(color = Color(0xFF989898)) | |
| ) | |
| Spacer( | |
| modifier = Modifier.height(4.dp) | |
| ) | |
| OutlinedTextField( | |
| modifier = Modifier.fillMaxWidth(), | |
| value = value, | |
| onValueChange = onValueChange, | |
| textStyle = DoMaTypography.labelLarge.copy(color = Color.White), | |
| shape = RoundedCornerShape(12.dp), | |
| singleLine = true, | |
| placeholder = { | |
| Text( | |
| text = "๋น๋ฐ๋ฒํธ๋ฅผ ์ ๋ ฅํด์ฃผ์ธ์.", | |
| style = DoMaTypography.labelLarge.copy(color = Color(0xFF989898)) | |
| ) | |
| }, | |
| visualTransformation = if (passwordVisible) | |
| VisualTransformation.None | |
| else | |
| PasswordVisualTransformation(), | |
| trailingIcon = { | |
| IconButton(onClick = { passwordVisible = !passwordVisible }) { | |
| Icon( | |
| imageVector = if (passwordVisible) | |
| Icons.Filled.Visibility | |
| else | |
| Icons.Filled.VisibilityOff, | |
| contentDescription = if (passwordVisible) | |
| "๋น๋ฐ๋ฒํธ ์จ๊ธฐ๊ธฐ" | |
| else | |
| "๋น๋ฐ๋ฒํธ ํ์" | |
| ) | |
| } | |
| }, | |
| colors = TextFieldDefaults.outlinedTextFieldColors( | |
| backgroundColor = Color(0xFF1E1E1E), | |
| cursorColor = Color.White, | |
| focusedBorderColor = Color(0xFFB9B9B9), | |
| unfocusedBorderColor = Color(0xFFB9B9B9) | |
| ) | |
| ) | |
| } | |
| } |
| clientId = "ghskfend", | ||
| redirectUri = "ghskfen" |
There was a problem hiding this comment.
๋ณด์ ์ทจ์ฝ์ : ํ๋์ฝ๋ฉ๋ ์ธ์ฆ ์ ๋ณด
ํด๋ผ์ด์ธํธ ID์ ๋ฆฌ๋ค์ด๋ ํธ URI๊ฐ ํ๋์ฝ๋ฉ๋์ด ์์ต๋๋ค. ์ด๋ ์ฌ๊ฐํ ๋ณด์ ์ํ์ ์ด๋ํ ์ ์์ต๋๋ค.
- clientId = "ghskfend",
- redirectUri = "ghskfen"
+ clientId = BuildConfig.CLIENT_ID,
+ redirectUri = BuildConfig.REDIRECT_URI๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| clientId = "ghskfend", | |
| redirectUri = "ghskfen" | |
| clientId = BuildConfig.CLIENT_ID, | |
| redirectUri = BuildConfig.REDIRECT_URI |
| fun SignInSubScreen( | ||
| modifier: Modifier = Modifier, | ||
| ClickButton: Boolean, | ||
| gAuthLogin: (String) -> Unit, | ||
| leIsClickLoginButton: () -> Unit, | ||
| ) { | ||
| Column( | ||
| modifier = modifier | ||
| .fillMaxSize() | ||
| .background(color = Color(0xFF1E1E1E)) | ||
| .padding(horizontal = 20.dp), | ||
| verticalArrangement = Arrangement.Center, | ||
| horizontalAlignment = Alignment.CenterHorizontally | ||
| ) { | ||
| Column( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .weight(1f), | ||
| verticalArrangement = Arrangement.Center | ||
| ) { | ||
| Row( | ||
| modifier = Modifier.fillMaxWidth(), | ||
| verticalAlignment = Alignment.Bottom, | ||
| horizontalArrangement = Arrangement.Start | ||
| ) { | ||
| Text( | ||
| text = "์์ด๋", | ||
| style = DoMaTypography.headlineSmall.copy(color = Color(0xFF9AD54A)), | ||
| ) | ||
| Text( | ||
| text = "์", | ||
| style = DoMaTypography.headlineSmall.copy(color = Color(0xFFFAFAFA)), | ||
| ) | ||
| Text( | ||
| text = " ๋น๋ฐ๋ฒํธ", | ||
| style = DoMaTypography.headlineSmall.copy(color = Color(0xFF9AD54A)), | ||
| ) | ||
| Text( | ||
| text = "๋ฅผ ์ ๋ ฅํด์ฃผ์ธ์!", | ||
| style = DoMaTypography.headlineSmall.copy(color = Color(0xFFFAFAFA)), | ||
| ) | ||
| } | ||
|
|
||
| Spacer(modifier = Modifier.height(20.dp)) | ||
|
|
||
| DoMaInputID( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| ) | ||
|
|
||
| Spacer(modifier = Modifier.height(12.dp)) | ||
|
|
||
| DoMaInputPassword( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| ) | ||
| } | ||
|
|
||
| DoMaLoginButton( | ||
| onClick = leIsClickLoginButton, | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(bottom = 30.dp) | ||
| ) | ||
|
|
||
| if (ClickButton) { | ||
| GAuthSigninWebView( | ||
| clientId = "ghskfend", | ||
| redirectUri = "ghskfen" | ||
| ) { code -> | ||
| gAuthLogin(code) | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
๐ ๏ธ Refactor suggestion
์๋ฌ ์ฒ๋ฆฌ ๋ฐ ์ฌ์ฉ์ ํผ๋๋ฐฑ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.
- ๋ก๊ทธ์ธ ์คํจ ์ ์๋ฌ ์ฒ๋ฆฌ๊ฐ ํ์ํฉ๋๋ค.
- ์ฌ์ฉ์์๊ฒ ์ ์ ํ ํผ๋๋ฐฑ์ ์ ๊ณตํด์ผ ํฉ๋๋ค.
- ๋คํธ์ํฌ ์ํ ์ฒ๋ฆฌ๊ฐ ํ์ํฉ๋๋ค.
fun SignInSubScreen(
modifier: Modifier = Modifier,
ClickButton: Boolean,
gAuthLogin: (String) -> Unit,
leIsClickLoginButton: () -> Unit,
+ loginState: LoginState,
+ errorMessage: String? = null,
) {
+ var showError by remember { mutableStateOf(false) }
+
+ LaunchedEffect(errorMessage) {
+ errorMessage?.let {
+ showError = true
+ }
+ }
+
Column(
// ... existing code ...
) {
+ if (showError) {
+ Text(
+ text = errorMessage ?: "๋ก๊ทธ์ธ ์ค ์ค๋ฅ๊ฐ ๋ฐ์ํ์ต๋๋ค.",
+ color = Color.Red,
+ modifier = Modifier.padding(bottom = 8.dp)
+ )
+ }
+
+ when (loginState) {
+ LoginState.Loading -> {
+ CircularProgressIndicator()
+ }
+ LoginState.Error -> {
+ // Error UI
+ }
+ else -> {
// ... existing content ...
+ }
+ }
}
}
+enum class LoginState {
+ Idle,
+ Loading,
+ Success,
+ Error
+}๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| fun SignInSubScreen( | |
| modifier: Modifier = Modifier, | |
| ClickButton: Boolean, | |
| gAuthLogin: (String) -> Unit, | |
| leIsClickLoginButton: () -> Unit, | |
| ) { | |
| Column( | |
| modifier = modifier | |
| .fillMaxSize() | |
| .background(color = Color(0xFF1E1E1E)) | |
| .padding(horizontal = 20.dp), | |
| verticalArrangement = Arrangement.Center, | |
| horizontalAlignment = Alignment.CenterHorizontally | |
| ) { | |
| Column( | |
| modifier = Modifier | |
| .fillMaxWidth() | |
| .weight(1f), | |
| verticalArrangement = Arrangement.Center | |
| ) { | |
| Row( | |
| modifier = Modifier.fillMaxWidth(), | |
| verticalAlignment = Alignment.Bottom, | |
| horizontalArrangement = Arrangement.Start | |
| ) { | |
| Text( | |
| text = "์์ด๋", | |
| style = DoMaTypography.headlineSmall.copy(color = Color(0xFF9AD54A)), | |
| ) | |
| Text( | |
| text = "์", | |
| style = DoMaTypography.headlineSmall.copy(color = Color(0xFFFAFAFA)), | |
| ) | |
| Text( | |
| text = " ๋น๋ฐ๋ฒํธ", | |
| style = DoMaTypography.headlineSmall.copy(color = Color(0xFF9AD54A)), | |
| ) | |
| Text( | |
| text = "๋ฅผ ์ ๋ ฅํด์ฃผ์ธ์!", | |
| style = DoMaTypography.headlineSmall.copy(color = Color(0xFFFAFAFA)), | |
| ) | |
| } | |
| Spacer(modifier = Modifier.height(20.dp)) | |
| DoMaInputID( | |
| modifier = Modifier | |
| .fillMaxWidth() | |
| ) | |
| Spacer(modifier = Modifier.height(12.dp)) | |
| DoMaInputPassword( | |
| modifier = Modifier | |
| .fillMaxWidth() | |
| ) | |
| } | |
| DoMaLoginButton( | |
| onClick = leIsClickLoginButton, | |
| modifier = Modifier | |
| .fillMaxWidth() | |
| .padding(bottom = 30.dp) | |
| ) | |
| if (ClickButton) { | |
| GAuthSigninWebView( | |
| clientId = "ghskfend", | |
| redirectUri = "ghskfen" | |
| ) { code -> | |
| gAuthLogin(code) | |
| } | |
| } | |
| } | |
| } | |
| fun SignInSubScreen( | |
| modifier: Modifier = Modifier, | |
| ClickButton: Boolean, | |
| gAuthLogin: (String) -> Unit, | |
| leIsClickLoginButton: () -> Unit, | |
| loginState: LoginState, | |
| errorMessage: String? = null, | |
| ) { | |
| var showError by remember { mutableStateOf(false) } | |
| LaunchedEffect(errorMessage) { | |
| errorMessage?.let { | |
| showError = true | |
| } | |
| } | |
| Column( | |
| modifier = modifier | |
| .fillMaxSize() | |
| .background(color = Color(0xFF1E1E1E)) | |
| .padding(horizontal = 20.dp), | |
| verticalArrangement = Arrangement.Center, | |
| horizontalAlignment = Alignment.CenterHorizontally | |
| ) { | |
| if (showError) { | |
| Text( | |
| text = errorMessage ?: "๋ก๊ทธ์ธ ์ค ์ค๋ฅ๊ฐ ๋ฐ์ํ์ต๋๋ค.", | |
| color = Color.Red, | |
| modifier = Modifier.padding(bottom = 8.dp) | |
| ) | |
| } | |
| when (loginState) { | |
| LoginState.Loading -> { | |
| CircularProgressIndicator() | |
| } | |
| LoginState.Error -> { | |
| // Error UI | |
| } | |
| else -> { | |
| Column( | |
| modifier = Modifier | |
| .fillMaxWidth() | |
| .weight(1f), | |
| verticalArrangement = Arrangement.Center | |
| ) { | |
| Row( | |
| modifier = Modifier.fillMaxWidth(), | |
| verticalAlignment = Alignment.Bottom, | |
| horizontalArrangement = Arrangement.Start | |
| ) { | |
| Text( | |
| text = "์์ด๋", | |
| style = DoMaTypography.headlineSmall.copy(color = Color(0xFF9AD54A)), | |
| ) | |
| Text( | |
| text = "์", | |
| style = DoMaTypography.headlineSmall.copy(color = Color(0xFFFAFAFA)), | |
| ) | |
| Text( | |
| text = " ๋น๋ฐ๋ฒํธ", | |
| style = DoMaTypography.headlineSmall.copy(color = Color(0xFF9AD54A)), | |
| ) | |
| Text( | |
| text = "๋ฅผ ์ ๋ ฅํด์ฃผ์ธ์!", | |
| style = DoMaTypography.headlineSmall.copy(color = Color(0xFFFAFAFA)), | |
| ) | |
| } | |
| Spacer(modifier = Modifier.height(20.dp)) | |
| DoMaInputID( | |
| modifier = Modifier | |
| .fillMaxWidth() | |
| ) | |
| Spacer(modifier = Modifier.height(12.dp)) | |
| DoMaInputPassword( | |
| modifier = Modifier | |
| .fillMaxWidth() | |
| ) | |
| } | |
| DoMaLoginButton( | |
| onClick = leIsClickLoginButton, | |
| modifier = Modifier | |
| .fillMaxWidth() | |
| .padding(bottom = 30.dp) | |
| ) | |
| if (ClickButton) { | |
| GAuthSigninWebView( | |
| clientId = "ghskfend", | |
| redirectUri = "ghskfen" | |
| ) { code -> | |
| gAuthLogin(code) | |
| } | |
| } | |
| } | |
| } | |
| } | |
| } | |
| enum class LoginState { | |
| Idle, | |
| Loading, | |
| Success, | |
| Error | |
| } |
| if (ClickButton) { | ||
| GAuthSigninWebView( | ||
| clientId = "ghskfend", | ||
| redirectUri = "ghskfen" | ||
| ) { code -> | ||
| gAuthLogin(code) | ||
| } | ||
| } |
There was a problem hiding this comment.
๋ณด์ ๊ฐํ์ ์ค๋ฅ ์ฒ๋ฆฌ๊ฐ ํ์ํฉ๋๋ค.
- Google ์ธ์ฆ ์ ๋ณด๊ฐ ์ฝ๋์ ํ๋์ฝ๋ฉ๋์ด ์์ด ๋ณด์์ ์ํํฉ๋๋ค.
- ์ธ์ฆ ๊ณผ์ ์์ ๋ฐ์ํ ์ ์๋ ์ค๋ฅ ์ฒ๋ฆฌ๊ฐ ์์ต๋๋ค.
๋ค์๊ณผ ๊ฐ์ ๊ฐ์ ์ด ํ์ํฉ๋๋ค:
- ์ธ์ฆ ์ ๋ณด๋ฅผ BuildConfig๋ ํ๊ฒฝ ๋ณ์๋ก ์ด๋:
- clientId = "ghskfend",
- redirectUri = "ghskfen"
+ clientId = BuildConfig.GAUTH_CLIENT_ID,
+ redirectUri = BuildConfig.GAUTH_REDIRECT_URI- ์ค๋ฅ ์ฒ๋ฆฌ ์ถ๊ฐ:
) { code ->
- gAuthLogin(code)
+ try {
+ gAuthLogin(code)
+ } catch (e: Exception) {
+ // ์ค๋ฅ ์ฒ๋ฆฌ ๋ก์ง ์ถ๊ฐ
+ }
}๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if (ClickButton) { | |
| GAuthSigninWebView( | |
| clientId = "ghskfend", | |
| redirectUri = "ghskfen" | |
| ) { code -> | |
| gAuthLogin(code) | |
| } | |
| } | |
| if (ClickButton) { | |
| GAuthSigninWebView( | |
| clientId = BuildConfig.GAUTH_CLIENT_ID, | |
| redirectUri = BuildConfig.GAUTH_REDIRECT_URI | |
| ) { code -> | |
| try { | |
| gAuthLogin(code) | |
| } catch (e: Exception) { | |
| // ์ค๋ฅ ์ฒ๋ฆฌ ๋ก์ง ์ถ๊ฐ | |
| } | |
| } | |
| } |
| fun SignInScreen( | ||
| modifier: Modifier = Modifier, | ||
| ClickButton: Boolean, | ||
| gAuthLogin: (String) -> Unit, | ||
| leIsClickLoginButton: () -> Unit, | ||
| ) { |
There was a problem hiding this comment.
๐ ๏ธ Refactor suggestion
๋งค๊ฐ๋ณ์ ์ด๋ฆ ๊ท์น๊ณผ ๋ฌธ์ํ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.
ClickButton๋งค๊ฐ๋ณ์๋ Kotlin ๋ช ๋ช ๊ท์น์ ๋ฐ๋ผclickButton์ผ๋ก ์์ ํด์ผ ํฉ๋๋ค.- ๊ฐ ๋งค๊ฐ๋ณ์์ ์ฉ๋๋ฅผ ์ค๋ช ํ๋ KDoc ๋ฌธ์ํ๊ฐ ํ์ํฉ๋๋ค.
๋ค์๊ณผ ๊ฐ์ด ์์ ํ๋ ๊ฒ์ ์ ์ํฉ๋๋ค:
+/**
+ * ๋ก๊ทธ์ธ ํ๋ฉด์ ํ์ํ๋ Composable ํจ์
+ *
+ * @param modifier ํ๋ฉด ๋ ์ด์์ ์์ ์
+ * @param clickButton Google ์ธ์ฆ ์น๋ทฐ ํ์ ์ฌ๋ถ
+ * @param gAuthLogin Google ์ธ์ฆ ์๋ฃ ์ ํธ์ถ๋๋ ์ฝ๋ฐฑ
+ * @param leIsClickLoginButton ๋ก๊ทธ์ธ ๋ฒํผ ํด๋ฆญ ์ ํธ์ถ๋๋ ์ฝ๋ฐฑ
+ */
@Composable
fun SignInScreen(
modifier: Modifier = Modifier,
- ClickButton: Boolean,
+ clickButton: Boolean,
gAuthLogin: (String) -> Unit,
leIsClickLoginButton: () -> Unit,
)๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| fun SignInScreen( | |
| modifier: Modifier = Modifier, | |
| ClickButton: Boolean, | |
| gAuthLogin: (String) -> Unit, | |
| leIsClickLoginButton: () -> Unit, | |
| ) { | |
| /** | |
| * ๋ก๊ทธ์ธ ํ๋ฉด์ ํ์ํ๋ Composable ํจ์ | |
| * | |
| * @param modifier ํ๋ฉด ๋ ์ด์์ ์์ ์ | |
| * @param clickButton Google ์ธ์ฆ ์น๋ทฐ ํ์ ์ฌ๋ถ | |
| * @param gAuthLogin Google ์ธ์ฆ ์๋ฃ ์ ํธ์ถ๋๋ ์ฝ๋ฐฑ | |
| * @param leIsClickLoginButton ๋ก๊ทธ์ธ ๋ฒํผ ํด๋ฆญ ์ ํธ์ถ๋๋ ์ฝ๋ฐฑ | |
| */ | |
| @Composable | |
| fun SignInScreen( | |
| modifier: Modifier = Modifier, | |
| clickButton: Boolean, | |
| gAuthLogin: (String) -> Unit, | |
| leIsClickLoginButton: () -> Unit, | |
| ) { | |
| // Function body goes here... | |
| } |
| ) { | ||
| Text( | ||
| text = "์์ด๋", | ||
| style = DoMaTypography.bodyMedium.copy(color = Color(0xFFFAFAFA)) |
There was a problem hiding this comment.
DoMaAndroidTheme ์ ์ฌ์ฉํด์ฃผ์ธ์
There was a problem hiding this comment.
์์ ํ์ต๋๋ค.
There was a problem hiding this comment.
Actionable comments posted: 2
๐งน Nitpick comments (2)
presentation/src/main/java/view/theme/color/ColorTheme.kt (1)
10-10: ์์ ์ด๋ฆ ์ปจ๋ฒค์ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.์ผ๊ด์ฑ์ ์ํด ๋ค์๊ณผ ๊ฐ์ด ์์ ํ๋ ๊ฒ์ ์ ์ํฉ๋๋ค:
Green์ ๋ค๋ฅธ ์์๋ค๊ณผ ๊ฐ์ด ๋ชจ๋ ๋๋ฌธ์๋กGREEN์ผ๋ก ์์ Background๋ ์ฉ๋๋ฅผ ๋ํ๋ด๋ ์ด๋ฆ์ด๋ฏ๋กBACKGROUND๋ก ์์ - abstract val Green: Color + abstract val GREEN: Color - abstract val Background: Color + abstract val BACKGROUND: ColorAlso applies to: 21-21
presentation/src/main/java/view/theme/color/DoMaColor.kt (1)
10-10: ์์ ์ด๋ฆ ์ปจ๋ฒค์ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.ColorTheme ํด๋์ค์ ๋ณ๊ฒฝ์ฌํญ๊ณผ ์ผ๊ด๋๊ฒ ๋ค์๊ณผ ๊ฐ์ด ์์ ํ๋ ๊ฒ์ ์ ์ํฉ๋๋ค:
- override val Green = Color(0xFF9AD54A) + override val GREEN = Color(0xFF9AD54A) - override val Background = Color(0xFF1E1E1E) + override val BACKGROUND = Color(0xFF1E1E1E)Also applies to: 20-20
๐ Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
โ Files ignored due to path filters (2)
buildSrc/build/kotlin/compileKotlin/cacheable/last-build.binis excluded by!**/*.binbuildSrc/build/kotlin/compileKotlin/local-state/build-history.binis excluded by!**/*.bin
๐ Files selected for processing (8)
presentation/src/main/java/view/signin/component/DoMaInputID.kt(1 hunks)presentation/src/main/java/view/signin/component/DoMaInputPassword.kt(1 hunks)presentation/src/main/java/view/signin/component/DoMaLoginButton.kt(1 hunks)presentation/src/main/java/view/signin/screen/SignInScreen.kt(1 hunks)presentation/src/main/java/view/signin/screen/SignInSubScreen.kt(1 hunks)presentation/src/main/java/view/theme/DomaAndroidTheme.kt(1 hunks)presentation/src/main/java/view/theme/color/ColorTheme.kt(2 hunks)presentation/src/main/java/view/theme/color/DoMaColor.kt(2 hunks)
๐ง Files skipped from review as they are similar to previous changes (4)
- presentation/src/main/java/view/signin/component/DoMaInputPassword.kt
- presentation/src/main/java/view/signin/component/DoMaLoginButton.kt
- presentation/src/main/java/view/signin/component/DoMaInputID.kt
- presentation/src/main/java/view/signin/screen/SignInSubScreen.kt
๐ Additional comments (3)
presentation/src/main/java/view/theme/DomaAndroidTheme.kt (1)
11-12: ํ์ดํฌ๊ทธ๋ํผ ์ถ๊ฐ๊ฐ ์ ๋์์ต๋๋ค!Material Design 3์ ๊ถ์ฅ์ฌํญ์ ๋ฐ๋ผ ํ์ดํฌ๊ทธ๋ํผ๋ฅผ ํ ๋ง์ ํตํฉํ ๊ฒ์ด ์ข์ต๋๋ค.
presentation/src/main/java/view/signin/screen/SignInScreen.kt (2)
21-26: ๋งค๊ฐ๋ณ์ ์ด๋ฆ ๊ท์น๊ณผ ๋ฌธ์ํ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.์ด์ ๋ฆฌ๋ทฐ ์๊ฒฌ๊ณผ ๋์ผํ ์ด์๊ฐ ์์ต๋๋ค.
96-101: ๋ณด์ ๊ฐํ์ ์ค๋ฅ ์ฒ๋ฆฌ๊ฐ ํ์ํฉ๋๋ค.์ด์ ๋ฆฌ๋ทฐ ์๊ฒฌ๊ณผ ๋์ผํ ์ด์๊ฐ ์์ต๋๋ค.
| Text( | ||
| text = "์๋ ํ์ธ์!", | ||
| style = DoMaTypography.headlineSmall.copy(color = colors.WHITE), | ||
| ) | ||
| Text( | ||
| text = "๋ก๊ทธ์ธ์ ํด๋ณผ๊น์?", | ||
| style = DoMaTypography.headlineSmall.copy(color = colors.Green), | ||
| ) |
There was a problem hiding this comment.
๐ ๏ธ Refactor suggestion
์ ๊ทผ์ฑ ๋ ์ด๋ธ ์ถ๊ฐ๊ฐ ํ์ํฉ๋๋ค.
์คํฌ๋ฆฐ ๋ฆฌ๋ ์ฌ์ฉ์๋ฅผ ์ํด ๋ชจ๋ ํ
์คํธ ์์์ contentDescription์ ์ถ๊ฐํด์ผ ํฉ๋๋ค.
Text(
text = "์๋
ํ์ธ์!",
+ modifier = Modifier.semantics { contentDescription = "ํ์ ๋ฉ์์ง" },
style = DoMaTypography.headlineSmall.copy(color = colors.WHITE),
)Also applies to: 65-76, 88-92
| Text( | ||
| text = "์์ด๋ ์ฐพ๊ธฐ", | ||
| style = DoMaTypography.labelLarge.copy(color = colors.WHITE), | ||
| ) | ||
| Text( | ||
| text = "|", | ||
| style = DoMaTypography.labelLarge.copy(color = colors.WHITE), | ||
| ) | ||
| Text( | ||
| text = "๋น๋ฐ๋ฒํธ ์ฐพ๊ธฐ", | ||
| style = DoMaTypography.labelLarge.copy(color = colors.WHITE), | ||
| ) |
There was a problem hiding this comment.
๐ ๏ธ Refactor suggestion
ํด๋ฆญ ๊ฐ๋ฅํ ํ ์คํธ์ ๋ํ ์ํธ์์ฉ ์ฒ๋ฆฌ๊ฐ ํ์ํฉ๋๋ค.
'์์ด๋ ์ฐพ๊ธฐ'์ '๋น๋ฐ๋ฒํธ ์ฐพ๊ธฐ' ํ ์คํธ๋ ํด๋ฆญ ๊ฐ๋ฅํด์ผ ํ๋ฉฐ, ์ ์ ํ ํผ๋๋ฐฑ์ ์ ๊ณตํด์ผ ํฉ๋๋ค.
+import androidx.compose.foundation.clickable
+import androidx.compose.material.ripple.rememberRipple
Text(
text = "์์ด๋ ์ฐพ๊ธฐ",
+ modifier = Modifier
+ .clickable(
+ interactionSource = remember { MutableInteractionSource() },
+ indication = rememberRipple(),
+ onClick = { /* TODO: ์์ด๋ ์ฐพ๊ธฐ ์ฒ๋ฆฌ */ }
+ ),
style = DoMaTypography.labelLarge.copy(color = colors.WHITE),
)Committable suggestion skipped: line range outside the PR's diff.
There was a problem hiding this comment.
Actionable comments posted: 1
โป๏ธ Duplicate comments (2)
presentation/src/main/java/view/signin/screen/SignInScreen.kt (2)
92-99:โ ๏ธ Potential issue๋ณด์ ์ทจ์ฝ์ : ์ธ์ฆ ์ ๋ณด๊ฐ ํ๋์ฝ๋ฉ๋์ด ์์ต๋๋ค.
- ํด๋ผ์ด์ธํธ ID์ ๋ฆฌ๋ค์ด๋ ํธ URI๋ฅผ ํ๊ฒฝ ๋ณ์๋ BuildConfig๋ก ์ด๋ํด์ผ ํฉ๋๋ค.
- ์ธ์ฆ ๊ณผ์ ์ ์ค๋ฅ ์ฒ๋ฆฌ๊ฐ ํ์ํฉ๋๋ค.
62-73: ๐ ๏ธ Refactor suggestionID/๋น๋ฐ๋ฒํธ ์ฐพ๊ธฐ ๊ธฐ๋ฅ ๊ตฌํ์ด ํ์ํฉ๋๋ค.
- ํ ์คํธ์ ํด๋ฆญ ์ด๋ฒคํธ ์ฒ๋ฆฌ๊ฐ ํ์ํฉ๋๋ค.
- ์์๋ค ์ฌ์ด์ ๊ฐ๊ฒฉ ์กฐ์ ์ด ํ์ํฉ๋๋ค.
+Row( + horizontalArrangement = Arrangement.spacedBy(8.dp), + modifier = Modifier.clickable { /* TODO: ID ์ฐพ๊ธฐ ์ฒ๋ฆฌ */ } +) { Text( text = "์์ด๋ ์ฐพ๊ธฐ", + modifier = Modifier.semantics { + contentDescription = "์์ด๋ ์ฐพ๊ธฐ ๋ฒํผ" + }, style = DoMaTypography.labelLarge.copy(color = colors.WHITE), ) }
๐งน Nitpick comments (2)
presentation/src/main/java/view/signin/screen/SignInScreen.kt (2)
39-46: ์ ๊ทผ์ฑ ๋ ์ด๋ธ๊ณผ ํ ์คํธ ์คํ์ผ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.
- ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ฌ์ฉ์๋ฅผ ์ํ ์ ๊ทผ์ฑ ๋ ์ด๋ธ ์ถ๊ฐ๊ฐ ํ์ํฉ๋๋ค.
- ํ ์คํธ ์คํ์ผ์ ์์๋ก ๋ถ๋ฆฌํ์ฌ ์ฌ์ฌ์ฉ์ฑ์ ๋์ด๋ ๊ฒ์ด ์ข์ต๋๋ค.
+val WelcomeTextStyle = DoMaTypography.headlineSmall Text( text = "์๋ ํ์ธ์!", + modifier = Modifier.semantics { + contentDescription = "ํ์ ์ธ์ฌ๋ง" + }, - style = DoMaTypography.headlineSmall.copy(color = colors.WHITE), + style = WelcomeTextStyle.copy(color = colors.WHITE), )
104-112: ํ๋ฆฌ๋ทฐ ํจ์ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.๋ค์ํ ์ํ์ ํ๋ฆฌ๋ทฐ๋ฅผ ์ถ๊ฐํ์ฌ UI ํ ์คํธ๋ฅผ ์ฉ์ดํ๊ฒ ํด์ผ ํฉ๋๋ค.
@Preview @Composable -fun PreviewSignInScreen() { +fun SignInScreenPreviews() { + Column { + // ๊ธฐ๋ณธ ์ํ + SignInScreen( + ClickButton = false, + gAuthLogin = {}, + leIsClickLoginButton = {} + ) + + // ๋ก๊ทธ์ธ ์งํ ์ค ์ํ + SignInScreen( + ClickButton = true, + gAuthLogin = {}, + leIsClickLoginButton = {} + ) + } }
๐ Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
๐ Files selected for processing (2)
presentation/src/main/java/view/signin/screen/SignInScreen.kt(1 hunks)presentation/src/main/java/view/signin/screen/SignInSubScreen.kt(1 hunks)
๐ง Files skipped from review as they are similar to previous changes (1)
- presentation/src/main/java/view/signin/screen/SignInSubScreen.kt
๐ Additional comments (1)
presentation/src/main/java/view/signin/screen/SignInScreen.kt (1)
17-23: ๋งค๊ฐ๋ณ์ ๋ช ๋ช ๊ท์น์ ์ค์ํด์ผ ํฉ๋๋ค.
ClickButton๋งค๊ฐ๋ณ์๋ Kotlin ๋ช ๋ช ๊ท์น์ ๋ฐ๋ผ ์นด๋ฉ ์ผ์ด์ค๋ก ์์ฑ๋์ด์ผ ํฉ๋๋ค.
| Text( | ||
| text = "์์ง ํจ๊ปํ์ง ๋ชปํ๋ค๋ฉด? ํ์๊ฐ์ ํ๊ธฐ", | ||
| style = DoMaTypography.labelLarge.copy(color = colors.WHITE), | ||
| textAlign = TextAlign.Center | ||
| ) |
There was a problem hiding this comment.
๐ ๏ธ Refactor suggestion
ํ์๊ฐ์ ๋งํฌ ๊ธฐ๋ฅ ๊ตฌํ์ด ํ์ํฉ๋๋ค.
ํ์๊ฐ์ ํ ์คํธ๋ฅผ ํด๋ฆญ ๊ฐ๋ฅํ ๋งํฌ๋ก ๊ตฌํํ๊ณ , ์๊ฐ์ ํผ๋๋ฐฑ์ ์ถ๊ฐํด์ผ ํฉ๋๋ค.
+Text(
+ text = "์์ง ํจ๊ปํ์ง ๋ชปํ๋ค๋ฉด? ",
+ style = DoMaTypography.labelLarge.copy(color = colors.WHITE),
+)
Text(
- text = "์์ง ํจ๊ปํ์ง ๋ชปํ๋ค๋ฉด? ํ์๊ฐ์
ํ๊ธฐ",
+ text = "ํ์๊ฐ์
ํ๊ธฐ",
+ modifier = Modifier
+ .clickable { /* TODO: ํ์๊ฐ์
ํ๋ฉด์ผ๋ก ์ด๋ */ }
+ .semantics { contentDescription = "ํ์๊ฐ์
ํ์ด์ง๋ก ์ด๋" },
style = DoMaTypography.labelLarge.copy(color = colors.WHITE),
textAlign = TextAlign.Center
)๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Text( | |
| text = "์์ง ํจ๊ปํ์ง ๋ชปํ๋ค๋ฉด? ํ์๊ฐ์ ํ๊ธฐ", | |
| style = DoMaTypography.labelLarge.copy(color = colors.WHITE), | |
| textAlign = TextAlign.Center | |
| ) | |
| Text( | |
| text = "์์ง ํจ๊ปํ์ง ๋ชปํ๋ค๋ฉด? ", | |
| style = DoMaTypography.labelLarge.copy(color = colors.WHITE), | |
| ) | |
| Text( | |
| text = "ํ์๊ฐ์ ํ๊ธฐ", | |
| modifier = Modifier | |
| .clickable { /* TODO: ํ์๊ฐ์ ํ๋ฉด์ผ๋ก ์ด๋ */ } | |
| .semantics { contentDescription = "ํ์๊ฐ์ ํ์ด์ง๋ก ์ด๋" }, | |
| style = DoMaTypography.labelLarge.copy(color = colors.WHITE), | |
| textAlign = TextAlign.Center | |
| ) |
There was a problem hiding this comment.
Actionable comments posted: 0
๐ญ Outside diff range comments (2)
presentation/src/main/java/view/Mypage/component/MyClean.kt (2)
37-38:โ ๏ธ Potential issueํ์ดํ๋ผ์ธ ์ค๋ฅ๋ฅผ ์์ ํด์ผ ํฉ๋๋ค.
UsersUiState.Fail์ผ์ด์ค์์ ๋ค์๊ณผ ๊ฐ์ ์ปดํ์ผ ์ค๋ฅ๊ฐ ๋ฐ์ํ์ต๋๋ค:
exception์ฐธ์กฐ๋ฅผ ์ฐพ์ ์ ์์error์ฐธ์กฐ๋ฅผ ์ฐพ์ ์ ์์๋ค์๊ณผ ๊ฐ์ด ์์ ํ๋ ๊ฒ์ ์ ์ํฉ๋๋ค:
- onErrorToast(usersUiState.exception, R.string.error) + onErrorToast(usersUiState.throwable, R.string.common_error)๐งฐ Tools
๐ช GitHub Actions: Android CI
[error] 37-39: Unresolved reference: exception
[error] 37-59: Unresolved reference: error
[error] 44-24: Type mismatch: inferred type is ImmutableList but UsersResponseModel was expected
44-45:โ ๏ธ Potential issueํ์ ๋ถ์ผ์น ์ค๋ฅ๋ฅผ ์์ ํด์ผ ํฉ๋๋ค.
data๋งค๊ฐ๋ณ์์ ํ์ ์ดUsersResponseModel์ด์ด์ผ ํ๋๋ฐImmutableList<UsersResponseModel>๊ฐ ์ ๋ฌ๋๊ณ ์์ต๋๋ค.๋ค์๊ณผ ๊ฐ์ด ์์ ํ๋ ๊ฒ์ ์ ์ํฉ๋๋ค:
- data = data + data = data.first() // ๋ฆฌ์คํธ์ ์ฒซ ๋ฒ์งธ ํญ๋ชฉ์ ์ฌ์ฉํ๊ฑฐ๋ + data = data[0] // ์ธ๋ฑ์ค๋ก ์ ๊ทผ๋๋
UsersResponseModelํ์ ์ ๋ฆฌ์คํธ ํ์ ์ผ๋ก ๋ณ๊ฒฝํ์ฌ ์์ ํ ์ ์์ต๋๋ค.๐งฐ Tools
๐ช GitHub Actions: Android CI
[error] 44-24: Type mismatch: inferred type is ImmutableList but UsersResponseModel was expected
[error] 121-40: Unresolved reference: roomNum
โป๏ธ Duplicate comments (2)
presentation/src/main/java/view/signin/screen/SignInScreen.kt (2)
122-127:โ ๏ธ Potential issue๋ณด์ ์ทจ์ฝ์ : ํ๋์ฝ๋ฉ๋ ์ธ์ฆ ์ ๋ณด
Google ์ธ์ฆ ์ ๋ณด๊ฐ ์ฝ๋์ ์ง์ ํ๋์ฝ๋ฉ๋์ด ์์ด ๋ณด์์ ์ํํฉ๋๋ค.
๋ค์๊ณผ ๊ฐ์ด ์์ ํ๋ ๊ฒ์ ์ ์ํฉ๋๋ค:
GAuthSigninWebView( - clientId = "ghskfend", - redirectUri = "ghskfen" + clientId = BuildConfig.GAUTH_CLIENT_ID, + redirectUri = BuildConfig.GAUTH_REDIRECT_URI ) { code -> - gAuthLogin(code) + try { + gAuthLogin(code) + } catch (e: Exception) { + // ์ค๋ฅ ์ฒ๋ฆฌ ๋ก์ง ์ถ๊ฐ + } }
45-52: ๐ ๏ธ Refactor suggestion์ ๊ทผ์ฑ ๋ ์ด๋ธ์ด ๋๋ฝ๋์์ต๋๋ค.
์คํฌ๋ฆฐ ๋ฆฌ๋ ์ฌ์ฉ์๋ฅผ ์ํ ์ ๊ทผ์ฑ ๋ ์ด๋ธ์ด ํ์ํฉ๋๋ค.
๋ค์๊ณผ ๊ฐ์ด ์์ ํ๋ ๊ฒ์ ์ ์ํฉ๋๋ค:
Text( text = "์๋ ํ์ธ์!", + modifier = Modifier.semantics { contentDescription = "ํ์ ์ธ์ฌ๋ง" }, style = DoMaTypography.headlineSmall.copy(color = colors.WHITE), ) Text( text = "๋ก๊ทธ์ธ์ ํด๋ณผ๊น์?", + modifier = Modifier.semantics { contentDescription = "๋ก๊ทธ์ธ ์๋ด ๋ฉ์์ง" }, style = DoMaTypography.headlineSmall.copy(color = colors.Green), )
๐งน Nitpick comments (1)
presentation/src/main/java/view/signin/screen/SignInScreen.kt (1)
74-75: TODO ์ฃผ์ ๊ตฌํ์ด ํ์ํฉ๋๋ค.์ฌ๋ฌ ๊ธฐ๋ฅ์ ๋ํ TODO ์ฃผ์์ด ๋จ์์์ต๋๋ค:
- ์์ด๋ ์ฐพ๊ธฐ
- ๋น๋ฐ๋ฒํธ ์ฐพ๊ธฐ
- ํ์๊ฐ์ ํ๋ฉด ์ด๋
์ด๋ฌํ ๊ธฐ๋ฅ๋ค์ ๊ตฌํ์ ๋์๋๋ฆด ์ ์์ต๋๋ค. ์๋ก์ด ์ด์๋ฅผ ์์ฑํ์ฌ ๊ฐ ๊ธฐ๋ฅ์ ๊ตฌํ์ ์ถ์ ํ์๊ฒ ์ต๋๊น?
Also applies to: 88-89, 114-115
๐ Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
โ Files ignored due to path filters (24)
buildSrc/build/classes/kotlin/main/Dependency$AndroidX.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Dependency$Coil.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Dependency$Compose.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Dependency$DataStore.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Dependency$Gauth.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Dependency$Google.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Dependency$Gradle.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Dependency$Hilt.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Dependency$Moshi.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Dependency$OkHttp.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Dependency$Retrofit.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Dependency$Test.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Dependency.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/ProjectProperties$Files.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/ProjectProperties$Id.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/ProjectProperties$NameSpace.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/ProjectProperties$Test.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/ProjectProperties$Versions.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/ProjectProperties.classis excluded by!**/*.classbuildSrc/build/classes/kotlin/main/Versions.classis excluded by!**/*.classbuildSrc/build/kotlin/compileKotlin/cacheable/last-build.binis excluded by!**/*.binbuildSrc/build/kotlin/compileKotlin/classpath-snapshot/shrunk-classpath-snapshot.binis excluded by!**/*.binbuildSrc/build/kotlin/compileKotlin/local-state/build-history.binis excluded by!**/*.binbuildSrc/build/libs/buildSrc.jaris excluded by!**/*.jar
๐ Files selected for processing (5)
.idea/other.xml(2 hunks)buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/counters.tab(0 hunks)presentation/src/main/java/view/Mypage/component/MyClean.kt(5 hunks)presentation/src/main/java/view/signin/screen/SignInScreen.kt(1 hunks)presentation/src/main/java/view/signin/screen/SignInSubScreen.kt(1 hunks)
๐ค Files with no reviewable changes (1)
- buildSrc/build/kotlin/compileKotlin/cacheable/caches-jvm/lookups/counters.tab
๐ง Files skipped from review as they are similar to previous changes (1)
- presentation/src/main/java/view/signin/screen/SignInSubScreen.kt
๐งฐ Additional context used
๐ช GitHub Actions: Android CI
presentation/src/main/java/view/Mypage/component/MyClean.kt
[error] 37-39: Unresolved reference: exception
[error] 37-59: Unresolved reference: error
[error] 44-24: Type mismatch: inferred type is ImmutableList but UsersResponseModel was expected
[error] 121-40: Unresolved reference: roomNum
๐ Additional comments (3)
.idea/other.xml (2)
61-71: ์๋ก์ด ์ผ์ฑ A35 ๊ธฐ๊ธฐ ์ ๋ณด ์ถ๊ฐ ํ์ธ ์์ฒญ:์ด ๋ธ๋ก์ ์๋ก์ด ์ผ์ฑ A35 ๊ธฐ๊ธฐ์ ์ ๋ณด๋ฅผ ์ถ๊ฐํ ๋ถ๋ถ์ ๋๋ค.
๊ฐ ์ต์ ๊ฐ(์: API, ๋ธ๋๋, codename, id, ์ ์กฐ์ฌ, ๊ธฐ๊ธฐ๋ช , screenDensity, screenX, screenY)์ด ์ฌ๋ฐ๋ฅด๊ฒ ์ ๋ ฅ๋์๋์ง ํ์ธํด ์ฃผ์ธ์. ํนํ,codename์ด "a35x"๋ก ์ค์ ๋ ์ ์ด ํ๋ก์ ํธ์ ๊ธฐ์กด ๋ช ๋ช ๊ท์น๊ณผ ์ผ๊ด๋๋์ง ๊ฒํ ๋ถํ๋๋ฆฝ๋๋ค.
425-435: ์๋ก์ด ๊ฐค๋ญ์ S21 Plus ๊ธฐ๊ธฐ ์ ๋ณด ์ถ๊ฐ ๊ฒ์ฆ ์์ฒญ:์ด ๋ธ๋ก์ ๊ฐค๋ญ์ S21 Plus ๊ธฐ๊ธฐ์ ์ ๋ณด๋ฅผ ์ถ๊ฐํ ๋ถ๋ถ์ ๋๋ค.
ํนํ,screenDensity๊ฐ์ด "394"๋ก ์ค์ ๋ ๊ฒ์ด ์๋ํ ๊ฐ์ธ์ง ํ์ธํด ์ฃผ์๊ณ , ๋ค๋ฅธ ์ต์ ๋ค(brand, codename, id, manufacturer, name, screenX, screenY) ์ญ์ ํ์ ๋ช ๋ช ๊ท์น๊ณผ ๋ฐ์ดํฐ ์ผ๊ด์ฑ ์ธก๋ฉด์์ ์ ์ ํ์ง ๊ฒํ ๋ถํ๋๋ฆฝ๋๋ค.presentation/src/main/java/view/Mypage/component/MyClean.kt (1)
84-85: ์์ ํ ๋ง ๋ณ๊ฒฝ์ ๋ํ ๊ฒํ ๊ฐ ํ์ํฉ๋๋ค.์ฌ๋ฌ
Text์ปดํฌ๋ํธ์์colors.GRAY์์colors.Green์ผ๋ก ์์์ด ๋ณ๊ฒฝ๋์์ต๋๋ค. ์ด๋ ์๊ฐ์ ์ผ๊ด์ฑ๊ณผ ์ ๊ทผ์ฑ์ ์ํฅ์ ๋ฏธ์น ์ ์์ต๋๋ค.๋ค์ ์คํฌ๋ฆฝํธ๋ฅผ ์คํํ์ฌ ์์ ๋๋น๋ฅผ ํ์ธํ์ธ์:
#!/usr/bin/python3 from colorsys import rgb_to_hls def check_contrast(color_hex): # 0xFF9AD54A to RGB r = int(color_hex[4:6], 16) / 255.0 g = int(color_hex[6:8], 16) / 255.0 b = int(color_hex[2:4], 16) / 255.0 # Convert to HLS h, l, s = rgb_to_hls(r, g, b) # Check lightness for readability if l < 0.5: print(f"Warning: Color {color_hex} might be too dark for good readability") print(f"Lightness value: {l:.2f}") # Check the new green color check_contrast("0xFF9AD54A")Also applies to: 126-127, 156-157, 186-187, 216-217
๐งฐ Tools
๐ช GitHub Actions: Android CI
[error] 121-40: Unresolved reference: roomNum
๐ก ๊ฐ์
SignIn Page๋ฅผ ํผ๋ธ๋ฆฌ์ฑ ํ์ต๋๋ค.
๐ ์์ ๋ด์ฉ
SingIn Page ํผ๋ธ๋ฆฌ์ฑ, DoMaLogin, DoMaInputId, DoMaInputPassword๊ตฌํ
๐ ๋ณ๊ฒฝ์ฌํญ
SignIn Page์ screen๊ณผ component
๐โโ๏ธ ์ง๋ฌธ์ฌํญ
๐ด ์ฌ์ฉ๋ฐฉ๋ฒ
๐ธ ๊ธฐํ
Summary by CodeRabbit
New Features
Bug Fixes
Style