Skip to content

Cleaning up photon vision estimator code. #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rokadias wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cleaning up photon vision estimator code. #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/java/xbot/common/injection/modules/RobotModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import xbot.common.properties.TableProxy;
import xbot.common.properties.XPropertyManager;
import xbot.common.subsystems.vision.AprilTagVisionIOFactory;
import xbot.common.subsystems.vision.AprilTagVisionIOPhotonVision;
import xbot.common.subsystems.vision.AprilTagVisionIOPhotonVisionEstimator;

/**
Expand Down
194 changes: 0 additions & 194 deletions src/main/java/xbot/common/subsystems/vision/AprilTagVisionIOPhotonVision.java
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/main/java/xbot/common/subsystems/vision/AprilTagVisionIOPhotonVisionSimulated.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
* IO implementation for a simulated PhotonVision environment.
* Based on the AdvantageKit sample implementation by team 6328.
*/
public class AprilTagVisionIOPhotonVisionSimulated extends AprilTagVisionIOPhotonVision {
public class AprilTagVisionIOPhotonVisionSimulated extends AprilTagVisionIOPhotonVisionEstimator {

@AssistedFactory
public abstract static class FactoryImpl implements AprilTagVisionIOFactory {
Expand All @@ -55,7 +55,7 @@ public abstract static class FactoryImpl implements AprilTagVisionIOFactory {
@AssistedInject
public AprilTagVisionIOPhotonVisionSimulated(@Assisted String name, @Assisted Transform3d robotToCamera,
AprilTagFieldLayout fieldLayout, Lazy<SimulatedPositionSupplier> poseSupplier, PropertyFactory pf) {
super(name, robotToCamera, fieldLayout);
super(name, robotToCamera, fieldLayout, pf);

this.poseSupplier = poseSupplier;

Expand Down