Conversation
# Conflicts: # src/main/java/competition/operator_interface/OperatorCommandMap.java
aschokking
reviewed
Mar 12, 2025
Contributor
There was a problem hiding this comment.
Is there an off the shelf library we could use for this math?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Was thinking about a different kind of spline follower, pathing along the spline directly rather than creating several intermediate points and re-using the SimpleSwerveTrajectory. Overall felt a little easier to tune.
Is also about 80% of the way to hooking up the NeoTrellis buttons to scoring/collection command groups using said splines, which should allow for a relatively simple drop-in of a more advanced source of splines (e.g. the Orin)
Asana task URL:
Whats changing?
Questions/notes for reviewers
How this was tested
Video/screenshots (from simulator or live robot)
PR feedback legend