Conversation
State machines are very enjoyable to write
Contributor
|
Could you attach a video of it working in the sim? |
aschokking
previously requested changes
Mar 31, 2025
Distance Property + renaming
…eamXbot2025 into SafetyAndStealingAlgae
JohnGilb
approved these changes
Apr 2, 2025
| this.simulatedModulePositions = Optional.of(positions); | ||
| } | ||
|
|
||
| public static List<Pose2d> getBlueReefFacePoses() { |
Contributor
There was a problem hiding this comment.
⭐ I know you're just extending an existing pattern, but the approach here to finding the "nearest" involves creating a bunch of objects and then disposing of them afterwards. Would be nice to have something more like the following:
- At robot boot time, create a blue list and red list (only once)
- At execution time, choose a given list based on what alliance you are and do the
nearestcalculation.
Contributor
There was a problem hiding this comment.
I wouldn't change this now, but in a follow-up PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
So we won't ram into the wall & can possibly steal algae from opposition
Asana task URL:
Whats changing?
A whole new state machine! (Or am I just overcomplicating everything?)
Questions/notes for reviewers
Probably requires tuning the double properties...
How this was tested
Video/screenshots (from simulator or live robot)
PR feedback legend