Skip to content

Still give other motors some velocity#284

Open
Rongrrz wants to merge 2 commits intomainfrom
apply-rpm-to-other-motors-in-low-power-mode
Open

Still give other motors some velocity#284
Rongrrz wants to merge 2 commits intomainfrom
apply-rpm-to-other-motors-in-low-power-mode

Conversation

@Rongrrz
Copy link
Copy Markdown
Contributor

@Rongrrz Rongrrz commented Mar 15, 2026

Why are we doing this?

In low power mode, we need to still apply some velocity to other motors that are not our main motor such that our main motor does not get stuck.
@VictorChen1-1

Asana task URL:

Whats changing?

Questions/notes for reviewers

How this was tested

  • tested on robot
  • tested in simulator
  • unit tests added

Video/screenshots (from simulator or live robot)


PR feedback legend

Symbol Meaning
⭐ ⭐ ⭐ must be addressed
⭐ ⭐ should be addressed
something to consider, a good idea

@Rongrrz Rongrrz requested a review from a team March 15, 2026 00:47
@stephenjust
Copy link
Copy Markdown
Contributor

What's the motivation for this? I expect it would simiply throw away 2/3 of our fuel if we do this, because the shooter feeder will still push the same number of fuel to these shooters.

@Rongrrz
Copy link
Copy Markdown
Contributor Author

Rongrrz commented Mar 15, 2026

What's the motivation for this? I expect it would simiply throw away 2/3 of our fuel if we do this, because the shooter feeder will still push the same number of fuel to these shooters.

According to @aschokking if let's say we have the middle shooter as our primary shooting motor in low power mode, the fuel will sort of "jam" due to the other fuels in the left and right shooters...

@stephenjust
Copy link
Copy Markdown
Contributor

What's the motivation for this? I expect it would simiply throw away 2/3 of our fuel if we do this, because the shooter feeder will still push the same number of fuel to these shooters.

According to @aschokking if let's say we have the middle shooter as our primary shooting motor in low power mode, the fuel will sort of "jam" due to the other fuels in the left and right shooters...

We should be able to validate that assumption

&& motor.getHealth() == DeviceHealth.Healthy)
.toList();
for (var motor : otherMotors) {
motor.setVelocityTarget(lowPowerModeVelocity.get());
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should set the min value between lowPowerModeVelocity and velocity, otherwise when we're seeing 0rpm in general across all 3motors, this is going to cause 2 of them to spin right?

@aschokking
Copy link
Copy Markdown
Contributor

aschokking commented Mar 23, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants