Conversation
|
⭐⭐ Can you add some unit tests to prove this works? |
Rongrrz
left a comment
Rongrrz
left a comment
There was a problem hiding this comment.
If you are using interpolating tree map, you shouldn't have to do any rounding
|
|
||
| for (boolean zeroHood : new boolean[]{false, true}) { | ||
| for (int i = 0; i < 10; i++) { | ||
| double randomWidth = rand.nextDouble() * 4.03; // 4.03 is the width of the alliance zone |
There was a problem hiding this comment.
⭐ Can we store this value somewhere or have a function for calculation like what vision does? (And I'd think that they probably already have a function to get the width/height of the alliance zone)
|
|
||
| assertNotNull(data); | ||
|
|
||
| if (data.servoRatio() > 0) { |
There was a problem hiding this comment.
⭐ What's the reason of this check? Could you write a comment to explain why if servoRatio > 0 then it must be in the range [0.2, 1.0]
There was a problem hiding this comment.
Considered a lower bound for safety but now I think about it, I dont think i need it. The 1.0 is the maximum ratio, so it should never be over. Changing the bounds to 0.0 to 1.0
3 participants
Why are we doing this?
Finding distance to the hub so we can set a RPM and hood.
Asana task URL:
https://app.asana.com/1/2086102074315/project/1212432746991352/task/1213811082673949
Whats changing?
Changing method of finding distance to use a interpolatingTreeMap.
Questions/notes for reviewers
How this was tested
Video/screenshots (from simulator or live robot)
PR feedback legend