Skip to content

Adding a delay to collector intake after deploy.#415

Open
rokadias wants to merge 2 commits intomainfrom
saqib/keep-collector-running
Open

Adding a delay to collector intake after deploy.#415
rokadias wants to merge 2 commits intomainfrom
saqib/keep-collector-running

Conversation

@rokadias
Copy link
Copy Markdown
Contributor

Why are we doing this?

Have collector wheels running as long as possible to collect stragglers.

How this was tested

  • tested on robot
  • tested in simulator
  • unit tests added

Video/screenshots (from simulator or live robot)


PR feedback legend

Symbol Meaning
⭐ ⭐ ⭐ must be addressed
⭐ ⭐ should be addressed
something to consider, a good idea

@rokadias rokadias requested a review from a team April 10, 2026 19:05
@rokadias rokadias requested a review from Glowdisk as a code owner April 10, 2026 19:06
group.setName("CollectFromNeutralZone");

group.addCommands(driveToNeutralZoneProvider.get());
group.addCommands(new ParallelDeadlineGroup(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ ⭐ I suspect this isnt quite going to work, let's talk about it in person. Wrapping a single command in a ParallelDeadlineGroup basically is a noop. I thought you wanted to run the collector while driving back but they are in sequence now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants