Feat : 변경된 학과명 추가 및 수정 #277
Merged
+18
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiwoo-jo
requested changes
Feb 17, 2025
Contributor
huiwoo-jo
left a comment
huiwoo-jo
left a comment
There was a problem hiding this comment.
학과명에 대하여 코멘트 남겼습니다
확인부탁드려요!!
| items = | ||
| resources.getStringArray(R.array.dmu_department_list).toCollection(ArrayList<String>()) | ||
| items.sort() | ||
| resources.getStringArray(R.array.dmu_department_list).toCollection(ArrayList()) |
Comment on lines
33
to
34
|
|
||
| const val UNDECLARED_MAJOR_CODE = 701 |
Contributor
There was a problem hiding this comment.
UNDECLARED_MAJOR_CODE는 오류 코드처럼 보일 수도 있을거 같아요!
처음 보고서 오류 코드를 추가하신 불 알았어요.
LIBERAL_MAJOR_CODE, INTERDISCIPLINARY_CODE,
EXPLORATORY_MAJOR_CODE가 더 명확하지 않을까 제안해봅니다!
Comment on lines
10
to
15
| object Robot : Department("로봇공학과", CODE.ROBOT_ENGINE_CODE) | ||
| object Robot : Department("로봇소프트웨어과", CODE.ROBOT_ENGINE_CODE) | ||
| object Electrical : Department("전기공학과", CODE.ELECTRICAL_ENGINE_CODE) | ||
| object InfoElectrical : Department("정보전자공학과", CODE.INFO_ELECTRONIC_ENGINE_CODE) | ||
| object Semiconductor : Department("반도체전자공학과", CODE.SEMICONDUCTOR_ENGINE_CODE) | ||
| object InfoCommunication : Department("정보통신공학과", CODE.INFO_COMMUNICATION_ENGINE_CODE) | ||
| object FireManagement : Department("소방안전관리과", CODE.FIRE_MANAGEMENT_CODE) | ||
| object ComputerInfo : Department("컴퓨터정보공학과", CODE.COMPUTER_INFO_ENGINE_CODE) | ||
| object ComputerInfo : Department("웹응용소프트웨어공학과", CODE.COMPUTER_INFO_ENGINE_CODE) |
Contributor
There was a problem hiding this comment.
바뀐 학과명에 맞춰서 object명과 CODE를 변경해야 나중에 혼선이 없을거 같아요
아래처럼 바꾸면 어떨까요?
ROBOT_ENGINE_CODE -> ROBOT_SOFTWARE_CODE
ComputerInfo -> WebAppSofware
COMPUTER_INFO_ENGINE_CODE -> WEB_APP_SOFTWARE_ENGINE_CODE
| "호텔관광학과" -> HotelTourism | ||
| "경영정보학과" -> BusinessInfo | ||
| "빅데이터경영과" -> BigDataManagement | ||
| "자유전공학과" -> UndeclaredMajor |
Contributor
There was a problem hiding this comment.
위에 코드명을 바꾸게 된다면 같이 수정해야합니다!
- 변경된 학과명에 맞춰 상수 네이밍을 수정합니다.
… feat/add-new-department
huiwoo-jo
requested changes
Feb 17, 2025
Contributor
huiwoo-jo
left a comment
huiwoo-jo
left a comment
There was a problem hiding this comment.
자유전공학과 관련하여 수정이 안된 부분들이 있어 코멘트 남겨놨습니다!
| object HotelTourism : Department("호텔관광학과", CODE.HOTEL_TOURISM_CODE) | ||
| object BusinessInfo : Department("경영정보학과", CODE.MANAGEMENT_INFORMATION_CODE) | ||
| object BigDataManagement : Department("빅데이터경영과", CODE.BIG_DATA_MANAGEMENT_CODE) | ||
| object UndeclaredMajor : Department("자유전공학과", CODE.LIBERAL_MAJOR_CODE) |
Contributor
There was a problem hiding this comment.
여기도 같이 수정해야될거 같아요
Suggested change
| object UndeclaredMajor : Department("자유전공학과", CODE.LIBERAL_MAJOR_CODE) | |
| object LiberalMajor : Department("자유전공학과", CODE.LIBERAL_MAJOR_CODE) |
| "호텔관광학과" -> HotelTourism | ||
| "경영정보학과" -> BusinessInfo | ||
| "빅데이터경영과" -> BigDataManagement | ||
| "자유전공학과" -> UndeclaredMajor |
Contributor
There was a problem hiding this comment.
여기도 수정이요!
Suggested change
| "자유전공학과" -> UndeclaredMajor | |
| "자유전공학과" -> LiberalMajor |
Comment on lines
32
to
40
| "기계공학과" -> CODE.MECHANICAL_ENGINE_CODE | ||
| "기계설계공학과" -> CODE.MECHANICAL_DESIGN_CODE | ||
| "자동화공학과" -> CODE.AUTOMATION_ENGINE_CODE | ||
| "로봇공학과" -> CODE.ROBOT_ENGINE_CODE | ||
| "로봇공학과" -> CODE.ROBOT_SOFTWARE_CODE | ||
| "컴퓨터소프트웨어공학과" -> CODE.COMPUTER_SOFTWARE_ENGINE_CODE | ||
| "컴퓨터정보공학과" -> CODE.COMPUTER_INFO_ENGINE_CODE | ||
| "컴퓨터정보공학과" -> CODE.WEB_APP_SOFTWARE_ENGINE_CODE | ||
| "인공지능소프트웨어공학과" -> CODE.ARTIFICIAL_ENGINE_CODE | ||
| "전기공학과" -> CODE.ELECTRICAL_ENGINE_CODE | ||
| "정보전자공학과" -> CODE.INFO_ELECTRONIC_ENGINE_CODE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
✍️ 구현 내용
📷 구현 영상
IMG_9732.MOV
IMG_9733.MOV
✔️ 확인 사항