feature: Creative galacticraft gear inventory #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Roelymole merged 22 commits into TeamGalacticraft:main from MaverXka:creativeinventory

Jan 6, 2026

Contributor

MaverXka commented Jan 4, 2026

MaverXka added 7 commits

July 1, 2025 20:32


          Heavy duty instruments texture update

fa606f7

Redrew Heavy Duty items in a modern Minecraft style.


          Creative tab, GC switch buttons added.

22f2834


          Creative screen update

169d747


          update

db1e44b


          Almost finished

f7a7ac6


          Added config option to enable/disable creative gear inventory. Requir…

c2ff7d3

…ed translation for config.

  "config.galacticraft.misc": "Misc",
  "config.galacticraft.misc.creative": "Creative",
  "config.galacticraft.misc.creative.enable_gearinv" : "Enable Creative Gear Inventory",


          Pull request ready.

699d678

MaverXka marked this pull request as draft

January 4, 2026 14:58


          Revert "Heavy duty instruments texture update"

3ecda04

This reverts commit fa606f7.

MaverXka changed the title ~~feature: Creative galacticraft gear inventory implementation~~ feature: Creative galacticraft gear inventory

Roelymole requested changes

View reviewed changes

Contributor

Roelymole left a comment

Great work! Thanks for contributing!

This isn't necessarily an exhaustive review, but I feel like I am already in danger of overwhelming you with comments. A lot of the things I have picked up on are more a matter of style and following best practices.

Please put opening curly brackets on the same line (not on the next line) according to the Code style section of the contributing guidelines.

Please put spaces after commas as well as keywords such as if, for, while.
Preferably operators should have a space either side too.

You have overused accessors/invokers quite a bit to get this to work. I have left multiple comments which should hopefully guide you through how to replace these. Doing so should greatly reduce the number of double casts such as (AbstractContainerScreenAccessor) (Object) this that are required, which should be avoided where possible. This should have the added bonus of improving readability too!

If you have any questions please feel free to ask me.

src/main/generated/assets/galacticraft/lang/en_us.json Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/accessor/GCCreativeGuiSlots.java Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/client/gui/widget/RadioButton.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/client/gui/widget/RadioButton.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/client/gui/widget/RadioButton.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/accessor/GCCreativeGuiSlots.java Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/client/gui/widget/RadioButton.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/AbstractContainerMenuMixin.java Outdated Show resolved Hide resolved

Roelymole reviewed

View reviewed changes

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved


          Update

8aca5f5

MaverXka requested a review from Roelymole

January 4, 2026 23:35

MaverXka added 2 commits

January 5, 2026 15:02


          Update 2

e9ddc5a


          Updated CreativeScreenMixin

b56d206

Roelymole requested changes

View reviewed changes

Contributor

Roelymole left a comment

Thank you for making the changes I requested before! I have another batch of feedback for you. As you tidy up the code it becomes easier to spot some of these things, so continue with that as much as you can.

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/client/gui/widget/RadioButton.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/client/gui/widget/RadioButton.java Outdated Show resolved Hide resolved

src/main/generated/assets/galacticraft/lang/en_us.json Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved


          Final update (I hope)

009660b

MaverXka requested a review from Roelymole

January 6, 2026 00:42

MaverXka and others added 4 commits

January 6, 2026 16:02


          Really final update

c6c9a44

Creative switch button becomes invisible instead of moving out of screen


          Merge branch 'main' into creativeinventory

34b808a


          Fixed bug after merge

138e4a4


          Update CreativeScreenMixin.java

007a89f

MaverXka marked this pull request as ready for review

January 6, 2026 14:01

MaverXka added 3 commits

January 6, 2026 20:58


          spotless applied

ce46b26


          Update CreativeScreenMixin.java

fe7b756


          Update CreativeScreenMixin.java

2947a80

Roelymole reviewed

View reviewed changes

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved


          Update CreativeScreenMixin.java

d56d937

MaverXka requested a review from Roelymole

January 6, 2026 22:54


          Update CreativeScreenMixin.java

f123539

Roelymole reviewed

View reviewed changes

Contributor

Roelymole left a comment

A few little things and then I think we might be there!

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Outdated Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/mixin/client/CreativeScreenMixin.java Show resolved Hide resolved

src/main/java/dev/galacticraft/mod/client/gui/widget/RadioButton.java Outdated Show resolved Hide resolved


          Refactor RadioButton hover logic and clean up CreativeScreenMixin

Roelymole approved these changes

View reviewed changes

Contributor

Roelymole left a comment

Thank you very much for all the hard work!

Roelymole merged commit 78f8a7e into TeamGalacticraft:main

1 check passed

Roelymole added this to Galacticraft 5 Alpha

github-project-automation bot moved this to Done in Galacticraft 5 Alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet