Skip to content

Conversation

@choiseona
Copy link
Member

๐Ÿšจ Pull request ์ „์— ํ™•์ธํ•ด์•ผ ํ•  ์‚ฌํ•ญ( [x] ์ฒดํฌํ•ด์ฃผ์„ธ์š” )

  • ๋ฐ˜๋“œ์‹œ ํ™•์ธํ•  ๊ฒƒ!
    pull a topic/feature/bugfix branch ์—์„œ dev branch๋กœ PR์š”์ฒญํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.
    master/main์— ํ•˜์‹œ๋ฉด ์•ˆ๋ฉ๋‹ˆ๋‹ค.

  • ์ปค๋ฐ‹ ๋˜๋Š” ๋ชจ๋“  ์ปค๋ฐ‹์˜ ๋ฉ”์‹œ์ง€ ์Šคํƒ€์ผ์ด convention๊ณผ ์ผ์น˜ํ•˜๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.

  • PR์ž‘์—…์— ๋Œ€ํ•œ ์˜ค๋ฅธ์ชฝ์˜ ๋ผ๋ฒจ์„ ๋ถ™์—ฌ์ฃผ์„ธ์š”.

๐Ÿ“Œ ๊ฐœ์š”

  • ๋น„ํšจ์œจ์ ์ธ ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ์ง์ ‘ ๊ตฌํ˜„ ํ›„ ์‚ญ์ œ
  • ์•ˆ์“ฐ๋Š” ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ์‚ญ์ œ
  • ์ด๋ฏธ์ง€ ํฌ๋งท, ์‚ฌ์ด์ฆˆ ์ œํ•œ

closes #430

โœจ ์ž‘์—… ๋‚ด์šฉ

  • ๊ธฐ์กด์˜ antd๋ฅผ ์‚ฌ์šฉํ•ด์„œ ๋งŒ๋“  ๊ฒƒ์„ ์ง์ ‘ ๊ตฌํ˜„ํ•˜๊ณ  antd๋ฅผ ์ข…์†์„ฑ์—์„œ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ์ €ํฌ ํ”„๋กœ์ ํŠธ์—์„œ antd๋ฅผ ์ „์ฒด์ ์œผ๋กœ ์‚ฌ์šฉํ•˜์ง€ ์•Š๊ณ  ๋ถ€๋ถ„๋งŒ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ๋Š” ์ƒํ™ฉ์ž…๋‹ˆ๋‹ค.
    • ์ด ์ƒํ™ฉ์—์„œ ํฌ๊ธฐ๊ฐ€ ํฐ ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์ธ antd๋ฅผ ๊ทธ๋Œ€๋กœ ์œ ์ง€ํ•˜๋Š” ๊ฒƒ์ด ๋น„ํšจ์œจ์ ์ด๋ผ๊ณ  ์ƒ๊ฐํ•˜์—ฌ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • react hook form์„ ๋„์ž…ํ•จ์— ๋”ฐ๋ผ ๊ธฐ์กด์— ์‚ฌ์šฉํ–ˆ๋˜ formik, yup์„ ์‚ญ์ œํ–ˆ์Šต๋‹ˆ๋‹ค.
    • react hook form ๋งŒ์œผ๋กœ๋Š” ์ฝ”๋“œ๊ฐ€ ์ง€์ €๋ถ„ํ•ด yup์„ ๊ฐ™์ด ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์„ ๊ณ ๋ ค์ค‘์ž…๋‹ˆ๋‹ค.
  • antd๋ฅผ ์—†์•ฐ์— ๋”ฐ๋ผ datePicker ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋ฅผ ๋”ฐ๋กœ ์„ค์น˜ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
    • datePicker๋กœ ๊ฐ€์žฅ ๋งŽ์ด ์“ฐ์ด๋Š” ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋ฅผ ์„ค์น˜ํ•˜์˜€์Šต๋‹ˆ๋‹ค. ์ถ”๊ฐ€์ ์œผ๋กœ ํ•ด๋‹น ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋ฅด ์‚ฌ์šฉํ•˜๋ฉด์„œ date-fns๋„ ํ•„์š”ํ•œ๋ฐ ์ด๊ฒƒ์ด moment๋ฅผ ๋Œ€์ฒดํ•  ์ˆ˜ ์žˆ์–ด moment๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ์‚ญ์ œํ•ด์ฃผ์—ˆ์Šต๋‹ˆ๋‹ค.
    • moment๋ณด๋‹ค date-fns๊ฐ€ ํ›จ์”ฌ ๊ฐ€๋ณ์Šต๋‹ˆ๋‹ค.
  • ์“ฐ์ด์ง€ ์•Š๋Š” react-modal, modal ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋ฅผ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋ฐฑ์—”๋“œ api ๋กœ ๋ณด๋‚ด๊ฒŒ๋˜๋Š” ์ด๋ฏธ์ง€ ํฌ๋งท์„ jpg, jpeg, png, gif๋กœ ๋งŒ ๊ฐ€๋Šฅํ•˜๋„๋กํ•˜์˜€๊ณ , ์‚ฌ์ด์ฆˆ๋Š” 5MB๋กœ ์ œํ•œํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท(์„ ํƒ)

๐Ÿ”Š ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ(์„ ํƒ)

๐Ÿ“š ์ถ”๊ฐ€ ์‚ฌํ•ญ(์„ ํƒ)

- antd ์‚ฌ์šฉ์—์„œ ๊ณตํ†ต ์ปดํฌ๋„ŒํŠธ๋กœ ๋ณ€๊ฒฝ
- AdminTopicContent์˜ Pagination์— ์ ์šฉ
- AdminInstanceContent์˜ Pagination์— ์ ์šฉ
โ€ฆ Upload, UploadProps์„ antd ์—†์ด ๊ตฌํ˜„
- UserInformationEditForm์˜ antd Form ์‚ญ์ œํ•˜๊ณ  ์ง์ ‘ ๊ตฌํ˜„
- InterestCheckEdit์˜ antd Checkbox, Col, Row ์‚ญ์ œํ•˜๊ณ  ์ง์ ‘ ๊ตฌํ˜„
- ํ•„์š”์—†๋Š” InterestEdit ์ปดํฌ๋„ŒํŠธ ์‚ญ์ œ
- Checkbox ๊ณตํ†ต ์ปดํฌ๋„ŒํŠธ ๊ตฌํ˜„
@choiseona choiseona added the enhancement New feature or request label Dec 24, 2024
@choiseona choiseona requested a review from songmok December 24, 2024 16:53
@choiseona choiseona self-assigned this Dec 24, 2024
@vercel
Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitget โฌœ๏ธ Ignored (Inspect) Visit Preview Dec 24, 2024 5:00pm

@choiseona choiseona merged commit a0de841 into dev Dec 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants