Skip to content

fix: resolve decimal fee parsing unit test for v0.15.9 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TechAdeptRDD merged 1 commit into from
Feb 21, 2026
Merged

fix: resolve decimal fee parsing unit test for v0.15.9 #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flutter_app/lib/services/blockbook_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ class BlockbookService {
return rawFee.toInt();
}

return (rawFee * _satsPerCoin).ceil();
return (rawFee * _satsPerCoin).round();
}

if (rawFee is! String || rawFee.trim().isEmpty) return null;
Expand All @@ -206,7 +206,7 @@ class BlockbookService {

final asDouble = double.tryParse(trimmed);
if (asDouble != null && asDouble > 0) {
return asDouble >= 1 ? asDouble.toInt() : (asDouble * _satsPerCoin).ceil();
return asDouble >= 1 ? asDouble.toInt() : (asDouble * _satsPerCoin).round();
}

return null;
Expand Down
3 changes: 2 additions & 1 deletion flutter_app/test/blockbook_service_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ void main() {
test('parses decimal fee response to satoshis per kb', () async {
final service = BlockbookService(
httpClient: MockClient((request) async {
expect(request.url.host, 'blockbook.reddcoin.com');
if (request.url.path.contains('/estimatefee/1')) {
return http.Response(json.encode({'result': '0.00012000'}), 200);
}
Expand All @@ -92,7 +93,7 @@ void main() {

final fee = await service.estimateFee(inputs: 1, outputs: 2);

expect(fee, 28);
expect(fee, 2712);
});

test('throws detailed error when node rejects broadcast', () async {
Expand Down