Improve some types #106
Open
Improve some types #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocavue
commented
Nov 13, 2025
|
|
||
| import { Algorithm, type LineTypes, Mat, type NormTypes, RotatedRect } from "."; | ||
| import "../_cv"; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Remove cycling imports.
ocavue
commented
Nov 13, 2025
| * | ||
| */ | ||
| export type DecompTypes = any; | ||
| export type DecompTypes = number; |
Contributor
Author
There was a problem hiding this comment.
Change some types from any to number
ocavue
commented
Nov 13, 2025
|
|
||
| /** | ||
| * https://docs.opencv.org/master/d0/d13/classcv_1_1Feature2D.html | ||
| * https://docs.opencv.org/4.12.0/d0/d13/classcv_1_1Feature2D.html |
Contributor
Author
There was a problem hiding this comment.
Better to use a fixed version of the link. The link with master might get broken when a new major version is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stack pull request that is based on #105. You likely want to review and merge #105 first.
I explained my changes as comments in this PR.