Ai dev 3 #110
Ai dev 3 #110
Conversation
…l Helper detection - Add base Meta Pixel initialization script to HTML head section - Update FacebookPixelScript to use native fbq function (initialized in head) - Add support for DEAL_SCALE_FB_Pixel_ID environment variable - Maintain consent-based tracking (pixel initializes but only tracks after user consent) - Fixes Meta Pixel Helper detection issue on www.dealscale.io
- Remove unused googleAnalyticsId and googleTagManagerId variables - Add biome-ignore comments for required Meta Pixel code (dangerouslySetInnerHTML and noscript img) - Fix import organization in DeferredThirdParties component
- Add Facebook Pixel 'Lead' event tracking for redirects via /api/redirect and middleware - Extract Facebook Pixel fields (enabled, source, intent) from Notion database - Implement client-side tracking page (/redirect) with 600ms delay for pixel events - Preserve UTM parameters and query strings through redirect chain - Add comprehensive tests for API route, middleware, and mapper - Update Notion database schema documentation Tests: 36 passing (API route, middleware, mapper)
- Add unit tests (Vitest) for redirect page component - Add E2E browser tests (Playwright) for real browser validation - Create mock fbq utility for testing pixel calls - Test pixel event firing, timing validation, and UTM preservation - Verify redirect waits >=500ms before navigation - Add comprehensive test documentation Unit tests: 10 passing Coverage: Event firing, timing, routing, error handling
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (key !== "to" && key !== "fbSource" && key !== "fbIntent") { | ||
| trackingUrl.searchParams.set(key, value); | ||
| } | ||
| } | ||
| return NextResponse.redirect(trackingUrl); |
There was a problem hiding this comment.
When the middleware sees facebookPixelEnabled, it returns the client-side tracking redirect immediately (/redirect), so the Redirects (Calls) increment block just below (lines 508+) never runs. Any slug that has Facebook Pixel turned on will redirect correctly but will no longer update its Notion call counter, silently dropping metrics for those pages while non-pixel redirects still increment. Consider moving the counter increment before this return or invoking it for the pixel path as well.
Useful? React with 👍 / 👎.
No description provided.