Casandras Portfolio #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et för hårdkodat/inget innehåll
…PT give me a work around and it seems to work?!
…lso a SwitchButton
…s the figma design
… it will just show on some devices and work with padding bottom
Contributor
|
I still don't have access to your Figma file so I can't review |
Author
But i have given you access... so weird. Ill try again |
HIPPIEKICK
requested changes
Jun 9, 2025
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
You've met all requirements except for the Lighthouse one, see image below. Sort this out and you're good to go. PS. Nice design ⭐
Author
|
Okey! Nu har jag lagt till en role=img till diven och även ändrat min h4 till en h3 för att behålla rätt semantik för bättre accessabilty.
|
HIPPIEKICK
approved these changes
Jun 12, 2025
- Added expandable gallery section for projects with multiple images - Implemented conditional slide-up animation (disabled when gallery is open) - Added The Pensieve project with 4 gallery images - Added Coparenting App project with before/after design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I havnt had time to extract the svgs to files and havn't had the time to clean up sections and components, i totally agree!
https://holacarmensita.com/hola