-
Notifications
You must be signed in to change notification settings - Fork 55
New portfolio page with styled components #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New portfolio page with styled components #36
Conversation
|
Hi again, so this is the PR we should look at? And this is the Netlify link: Could you also share the Figma design you used and then I'll review 🥳 |
|
I never did a figma design i told jennie (im sure it was her but i could be
wrong) and she said it would be okay
…On Tue, Aug 5, 2025 at 4:51 PM Matilda Brunemalm ***@***.***> wrote:
*HIPPIEKICK* left a comment (Technigo/js-project-portfolio#36)
<#36 (comment)>
Hi again, so this is the PR we should look at? And this is the Netlify
link:
https://portfolio-new-darius.netlify.app/?
Could you also share the Figma design you used and then I'll review 🥳
—
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKQ46H532VYBCA2T6YAMGWD3MDAHLAVCNFSM6AAAAACDALS5ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNJVGU2DSOBYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Since following a design is the main requirement for this project, I cannot approve this project as it is right now. I would recommend you just follow one of the designs we provided so that you don't need to create your own. Request a re-review when you're done. |
|
it would be easier to just make an identical figma design than restyling
the the page
…On Thu, 21 Aug 2025 at 14:13, Matilda Brunemalm ***@***.***> wrote:
*HIPPIEKICK* left a comment (Technigo/js-project-portfolio#36)
<#36 (comment)>
Since following a design is the main requirement for this project, I
cannot approve this project as it is right now. I would recommend you just
follow one of the designs we provided so that you don't need to create your
own. Request a re-review when you're done.
—
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKQ46HZJA5OX36Q36D3Y45T3OWZVDAVCNFSM6AAAAACDALS5ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJQGM2DQMBSGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Or actually what do I know. I will take a look at your designs.
…On Thu, 21 Aug 2025 at 14:15, D Carter ***@***.***> wrote:
it would be easier to just make an identical figma design than restyling
the the page
On Thu, 21 Aug 2025 at 14:13, Matilda Brunemalm ***@***.***>
wrote:
> *HIPPIEKICK* left a comment (Technigo/js-project-portfolio#36)
> <#36 (comment)>
>
> Since following a design is the main requirement for this project, I
> cannot approve this project as it is right now. I would recommend you just
> follow one of the designs we provided so that you don't need to create your
> own. Request a re-review when you're done.
>
> —
> Reply to this email directly, view it on GitHub
> <#36 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BKQ46HZJA5OX36Q36D3Y45T3OWZVDAVCNFSM6AAAAACDALS5ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJQGM2DQMBSGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
ping |
netlify: https://darius-new-portfolio-school-version.netlify.app/