portfolio frida #41
Open
portfolio frida #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Npahlfer
reviewed
Dec 4, 2025
|
|
||
| useEffect(() => { | ||
| if (blog.description) { | ||
| fetch(blog.description) |
There was a problem hiding this comment.
This whole fetching of local markdown files feels a bit funky. You could have just imported them :)
Npahlfer
reviewed
Dec 4, 2025
| ))} | ||
|
|
||
| <ToggleButton $active={showAll} onClick={() => setShowAll(!showAll)}> | ||
| {!showAll && <TogglebtnIcon><ArrowIcon aria-hidden="true" /></TogglebtnIcon>} |
There was a problem hiding this comment.
A tip! This could have been written with one condition:
{showAll
? "Show fewer"
: (
<>
<TogglebtnIcon><ArrowIcon aria-hidden="true" /></TogglebtnIcon>
See more articles
</>
)
}
Npahlfer
reviewed
Dec 4, 2025
| <ProjectCard key={i} project={project} /> | ||
| ))} | ||
|
|
||
| <ToggleButton $active={showAll} onClick={() => setShowAll(!showAll)}> |
There was a problem hiding this comment.
Remember to use the previous state! setShowAll(show => !show)
Npahlfer
reviewed
Dec 4, 2025
| @@ -1,4 +1,16 @@ | |||
| /* global base styles */ | |||
There was a problem hiding this comment.
This could have been put into styled components GlobalStyles :)
Npahlfer
approved these changes
Dec 4, 2025
Npahlfer
left a comment
Npahlfer
left a comment
There was a problem hiding this comment.
Nicely done! Clever use of the theme and you use the styled props. Easy to read.
Some small improvements that I have commented on, but overall good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figma
Netlify