Nicolinas portfolio #47
Conversation
…ent for each project to display them in project section
…cognising changes from lower/uppercase
…n all devices, og tags added, readme edited, favicon bug fixed
| @@ -0,0 +1,17 @@ | |||
| import styled from 'styled-components' | |||
There was a problem hiding this comment.
Instead of defining a set of different Typographies like you have done in here, it would be nicer to define a component that can change (both the styling and the element) depending on the prop. Like we did in class:
https://github.com/Technigo/fall-2025-live-sessions/blob/main/week-14/styled-components/src/components/Typography.jsx
| @@ -1,4 +1,10 @@ | |||
| body { | |||
There was a problem hiding this comment.
You can put all of this in the globalStyles instead :)
| return ( | ||
| <ProjectContainer> | ||
| <H2>Featured projects</H2> | ||
| <Slider {...settings} style={{ width: '100%', gap: '32px' }}> |
There was a problem hiding this comment.
You could even have separated the Slider into its own component and then have some of your default settings defined in there with props for the other stuff that needs to change. That way you wouldnt have to define the settings for each use of the (slick) Slider :)
|
It would have been nice to see some use of a theme (for colors, fonts, spacing and media queries) in the styled components. And also to see some more data(content) in its own files to make it easy to change in one place. There was some repetition as well, but otherwise good job! |
| <Body>{props.date}</Body> | ||
| <H3>{props.title} </H3> | ||
| <Body>{props.text}</Body> | ||
| <ClearButton label='Read Article'/> |
There was a problem hiding this comment.
Try to create components that act as normal (DOM) elements. In this case for <ClearButton> I think it would have been better to utilize the children prop. Like this:
<ClearButton>Read Article</ClearButton>This feels more natural.
2 participants
Netlify: https://nicolina-portfolio.netlify.app/
Figma design: https://www.figma.com/design/R93nj48cFoqvvqrpuQo3sl/Nicolina-Portfolio?node-id=0-1&p=f&t=IBaQ5jE7ltzACpMd-0