-
Notifications
You must be signed in to change notification settings - Fork 55
Leon Ekelund Portfolio hand-in #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Npahlfer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
| </noscript> | ||
|
|
||
| <link rel="icon" type="image/x-icon" href="/src/assets/favicon.svg" /> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider removing the extra empty space here :)
artakjato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project is overall very well organized into separate components and it is easy to read. I had a few minor comments but nothing major to mention here.
Great job on adding you new projects!
| import HeaderSection from './sections/HeaderSection'; | ||
| import TechSection from './sections/TechSection'; | ||
| import ProjectsSection from './sections/ProjectsSection'; | ||
| // import ThoughtsSection from './sections/ThoughtsSection'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider removing commented out import from the final version
| <Info>0709752924</Info> | ||
| <Info>leongudmundssonekelund@gmail.com</Info> | ||
|
|
||
| <Icons> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The social media contacts do not appear on the page as they are empty.
Please include a link to your Figma design and a Netlify link.