Week 16: Authentication - Etna and Alma#332
Open
almaherris wants to merge 33 commits intoTechnigo:masterfrom
Open
Week 16: Authentication - Etna and Alma#332almaherris wants to merge 33 commits intoTechnigo:masterfrom
almaherris wants to merge 33 commits intoTechnigo:masterfrom
Conversation
set up user page
welcome page
Project auth etna
HIPPIEKICK
approved these changes
May 27, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Well named endpoints and straightforward structure! Keep up the good work 🚀
Comment on lines
+107
to
+111
| {loading ? ( | ||
| <div> | ||
| <p className="user-loading"> User being created...</p> | ||
| </div> | ||
| ) : ( |
Contributor
There was a problem hiding this comment.
Gold star for adding a loader indication! Render can be really slow ⌛
Comment on lines
+70
to
+72
| if (name === "" || email === "" || password === "") { | ||
| res.status(400).json({ message: "All fields are required" }); | ||
| } |
Contributor
There was a problem hiding this comment.
Keeping it DRY, I like it 😏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
Frontend: https://pink-authorization.netlify.app/
Backend: https://bubblegum-auth.onrender.com/
Collaborators
[caracal23, almaherris]