Open
Conversation
HIPPIEKICK
approved these changes
May 28, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Well done, code looks good 👍
Comment on lines
+15
to
+16
| "bcrypt": "^5.1.1", | ||
| "bcryptjs": "^2.4.3", |
Contributor
There was a problem hiding this comment.
I think one of these is enough?
Comment on lines
+46
to
+50
| const generateAccessToken = (userId) => { | ||
| return jwt.sign({ userId }, process.env.ACCESS_TOKEN_SECRET, { | ||
| expiresIn: "24h", | ||
| }); | ||
| }; |
Contributor
There was a problem hiding this comment.
Fun that you tried out jwt!
|
|
||
| //Registration Endpoint | ||
| //http://localhost:9000/register | ||
| app.post("/register", async (req, res) => { |
Contributor
There was a problem hiding this comment.
According to REST naming conventions, endpoints should be named after what they return or in this case create. So this endpoint could be named /users
| }); | ||
|
|
||
| // Sign-in Endpoint | ||
| app.post("/login", async (req, res) => { |
Contributor
There was a problem hiding this comment.
And this could be called /sessions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links
BE: https://project-auth-2zcr.onrender.com
FE: https://authentication-bmm.netlify.app/