Open
Conversation
Co-authored-by: Maja Schouenke <schouenkes@users.noreply.github.com>
Co-authored-by: Maja Schouenke <schouenkes@users.noreply.github.com> Co-authored-by: viktoria-olo <viktoria-olo@users.noreply.github.com>
Secondary
Co-authored-by: jyy009 <jyy009@users.noreply.github.com>
Co-authored-by: jyy009 <jyy009@users.noreply.github.com>
style session page
split up formData state management
add expressListEndpoints and update readme
AntonellaMorittu
approved these changes
May 30, 2024
Contributor
There was a problem hiding this comment.
Hello girls, good job implementing the auth for your final project! The app works well and it meets the requirements. I recommend to validate the input values like postcode and city, and add some rules to password or username (at the moment you can input letters in the postcode, numbers for city, and psw and username be just 1 character). it could be done either in the BE, for example:
password: {
type: String,
required: true,
validate: {
validator: function(v) {
return v.length >= 8;
},
message: props => `Password should be at least 8 characters long!`
}
}or in the FE. Other than that you're on a great track so keep it up! 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://heroic-beignet-77e068.netlify.app
Render
https://project-auth-kh49.onrender.com/
Collaborators
[viktoria-olo, schouenkes]