Project-Auth Lovisa, Axel, Alexandra#343
Open
Xikitita wants to merge 23 commits intoTechnigo:masterfrom
Open
Conversation
Co-authored-by: AHPIXI <AHPIXI@users.noreply.github.com>
AntonellaMorittu
approved these changes
May 30, 2024
Contributor
AntonellaMorittu
left a comment
There was a problem hiding this comment.
Hello team! You did a great job with your auth API and starting off your final project app. The app works well and it meets the requirements. The animations make it fun and you added some error messages to display for the user experience. This is very important, however try to be more specific with the reasons why it "couldn't create user", like if the email already exists. I recommend to validate the input values like name (now it accepts a number value), and add some rules to password or username (at the moment you can input psw and username of just 1 character). iI could be done either in the BE, for example:
password: {
type: String,
required: true,
validate: {
validator: function(v) {
return v.length >= 8;
},
message: props => `Password should be at least 8 characters long!`
}
}or in the FE, now you know how to ⭐
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://clever-scone-066fd8.netlify.app/
Collaborators
[Lovisaaberg, AHPIXI]