Skip to content

Conversation

@jessand77
Copy link

Comment on lines +18 to +22
<NavigationContainer>
<Tab.Navigator
screenOptions={({ route }) => ({
tabBarIcon: ({ focused, color, size }) => {
if (route.name === 'Home') {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like your tab navigation with the tab function in the bottom.

Comment on lines +7 to +9
const DOG_URL = 'https://dog.ceo/api/breed/samoyed/images/random'

const DogScreen = () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea with two api.s, one game and the dog images.
I love the dog theme!

Copy link

@lisabergstrom lisabergstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Jessica!
You have reached the general requirements. The code is easy to read and you have structured it in a good way and I love the dog theme!

Copy link

@EmmaaBerg EmmaaBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good job with your app Jessica! You have reached the requirements and it looks good on my phone. Really liked how you combined navigation and fetch from API. And also a good job with implementing what we have learned from the previous weeks :D

Comment on lines +9 to +11
import StartScreen from './screens/StartScreen'
import DogScreen from './screens/DogScreen'
import GameScreen from './screens/GameScreen'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice with different pages in your app! :D

@@ -0,0 +1,8 @@
export const Colors = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that you could store this in a separate file and then import it

)
}

const styles = StyleSheet.create({

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with the stylesheet! :D

@@ -0,0 +1,78 @@
import React from 'react'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice that you implemented an old project as the game :D

@@ -0,0 +1,28 @@
import React from 'react'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with a loader so the user can see something when there is waiting time :D

@@ -0,0 +1,33 @@
import React from 'react'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you created a separate component for the button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants