Project React Native App, Tiina #310
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llect data with expo sensors, added styling
sk-phan
reviewed
May 8, 2022
Comment on lines
+12
to
+15
| let [fontsLoaded] = useFonts({ | ||
| WorkSans_300Light, | ||
| WorkSans_400Regular, | ||
| }) |
There was a problem hiding this comment.
Super nice to see that you're using custom font here
sk-phan
reviewed
May 8, 2022
| setLoading(true) | ||
| fetch("https://www.boredapi.com/api/activity") | ||
| .then(res => res.json()) | ||
| .then(data => setTimeout(() => setFetchedData(data), 600)) |
There was a problem hiding this comment.
Perhaps, you can add .catch error here, in case the API is not successfully fetched
sk-phan
reviewed
May 8, 2022
|
|
||
| const changeImage = () => { | ||
| switch (fetchedData.type) { | ||
| case "social": |
sk-phan
reviewed
May 8, 2022
Comment on lines
+110
to
+144
| return <Image source={require("../assets/social.png")} | ||
| style={{ resizeMode: "contain", height: 280, width: 280 }} /> | ||
| break | ||
| case "cooking": | ||
| return <Image source={require("../assets/cooking.png")} | ||
| style={{ resizeMode: "contain", height: 280, width: 280 }} /> | ||
| break | ||
| case "busywork": | ||
| return <Image source={require("../assets/busywork.png")} | ||
| style={{ resizeMode: "contain", height: 280, width: 280 }} /> | ||
| break | ||
| case "education": | ||
| return <Image source={require("../assets/education.png")} | ||
| style={{ resizeMode: "contain", height: 280, width: 280 }} /> | ||
| break | ||
| case "diy": | ||
| return <Image source={require("../assets/diy.png")} | ||
| style={{ resizeMode: "contain", height: 280, width: 280 }} /> | ||
| break | ||
| case "recreational": | ||
| return <Image source={require("../assets/recreational.png")} | ||
| style={{ resizeMode: "contain", height: 280, width: 280 }} /> | ||
| break | ||
| case "charity": | ||
| return <Image source={require("../assets/charity.png")} | ||
| style={{ resizeMode: "contain", height: 280, width: 280 }} /> | ||
| break | ||
| case "music": | ||
| return <Image source={require("../assets/music.png")} | ||
| style={{ resizeMode: "contain", height: 280, width: 280 }} /> | ||
| break | ||
| default: | ||
| return <Image source={require("../assets/relaxing.png")} | ||
| style={{ resizeMode: "contain", height: 280, width: 280 }} /> | ||
| } |
There was a problem hiding this comment.
Another way to avoid repeating the code. You can return only the image source here:
return ".required(./assets/relaxing.png)"
, instead of rewriting them like this
<Image source={require("../assets/relaxing.png")}
style={{ resizeMode: "contain", height: 280, width: 280 }} />
Next, In the function in the line 164, we can replace it with :
<Image source={changeImage()}
style={{ resizeMode: "contain", height: 280, width: 280 }} />
Hope you find it helpful
sk-phan
reviewed
May 8, 2022
Comment on lines
+1
to
+15
| import React from "react" | ||
|
|
||
| import LottieView from "lottie-react-native" | ||
|
|
||
| const Loader = () => { | ||
| return ( | ||
| <> | ||
| <LottieView | ||
| source={require("../assets/bouncy-balls-loader.json")} | ||
| autoPlay | ||
| loop | ||
| /> | ||
| </> | ||
| ) | ||
| } |
There was a problem hiding this comment.
I was not able to apply the animation, it's nice to see how you did it
sk-phan
reviewed
May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.