[IMP] support customization of the custom conf path.#512
[IMP] support customization of the custom conf path.#512josep-tecnativa merged 3 commits intoTecnativa:masterfrom
Conversation
LoisRForgeFlow
force-pushed
the
custom-conf-dir
branch
2 times, most recently
from
e52ff69 to
0c53693
Compare
ap-wtioit
left a comment
ap-wtioit
left a comment
There was a problem hiding this comment.
A test would be nice (test_dotd has a fragment that tests custom/conf.d maybe we could expand this)
# ``custom/conf.d`` was properly concatenated
("grep", "test-conf", "auto/odoo.conf"),
./custom is copied onbuild into /opt/odoo/custom and is chowned to root:odoo. In dev adding additional directories should be fine (if one exports UID, GID properly). but in other environments there could be permission issues with reading custom conf.d that do not belong to odoo uid inside the container.
Can we ignore such permission issues?
MarcelSForgeFlow
force-pushed
the
custom-conf-dir
branch
from
062da84 to
6da8fb9
Compare
This allow you to potentially build different configuration files based on the environment you are using.
GuillemCForgeFlow
force-pushed
the
custom-conf-dir
branch
from
c1e555f to
7180737
Compare
Add assertions to verify that both `custom/conf.d` and `CUSTOM_CONF_DIR` directories are properly merged into `auto/odoo.conf`: - Move `test-conf` from `conf.d/` to `conf-test.d/` so it is only reachable via `CUSTOM_CONF_DIR` - Add `conf` to `conf.d/` with a unique key (`conf_d_test`) - Add `CUSTOM_CONF_DIR=/opt/odoo/custom/conf-test.d` to the test docker-compose environment - Assert both `conf_d_test` and `custom_conf_dir_test` appear in the generated `auto/odoo.conf` Using real key-value pairs inside `[options]` sections (rather than empty custom sections) ensures configparser reliably writes them to the output file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
GuillemCForgeFlow
force-pushed
the
custom-conf-dir
branch
from
7180737 to
cbb6395
Compare
|
@josep-tecnativa I'm not sure if you need to approve the tests' execution for this improvement. |
|
@josep-tecnativa there's an issue with one job https://github.com/Tecnativa/doodba/actions/runs/23144055090/job/67228455751 which seems unrelated to the changes being added here. any clues on how to fix? 🤔 |
|
@josep-tecnativa I can see the CI is green now. do you think we could get this merged? 🙂 |
|
LGTM |
5 participants
This allow you to potentially build different configuration files
based on the enviroment you are using.
@ForgeFlow