Backend/room wsc #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a room.
i.e.
{'type': 'message.filter.room(roomID)',
'content': [...] }
cganterh
requested changes
Oct 12, 2016
Member
cganterh
left a comment
cganterh
left a comment
There was a problem hiding this comment.
There are several copy-paste errors in this pull request.
There are other things that I'm not sure if they are necessary or not.
| @@ -0,0 +1,39 @@ | |||
| # -*- coding: UTF-8 -*- | |||
|
|
|||
| # COPYRIGHT (c) 2016 Cristóbal Ganter | |||
Member
There was a problem hiding this comment.
Maybe you should license this module as your own.
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| from .wsclass import RoomsWSC # noqa | ||
| from . import patches # noqa |
Member
There was a problem hiding this comment.
I see no reason to use noqa here.
| class RoomIsNotDefined(AttributeError): | ||
| """Raise when ``room`` is not defined. | ||
| ``course`` should be defined in the current instance of |
Member
There was a problem hiding this comment.
room should be defined ...
copy paste error
| """ | ||
|
|
||
| def __init__(self, *args): | ||
| """Initialize a new CourseIsNotDefined exception.""" |
| def __init__(self, *args): | ||
| """Initialize a new CourseIsNotDefined exception.""" | ||
| super().__init__( | ||
| 'Attempted to use the `course` attribute, but ' |
| # You should have received a copy of the GNU Affero General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| from .wsclass import RoomsWSC # noqa |
| from src.db import Course, User | ||
|
|
||
|
|
||
| class RoomsWSC(src.wsclass.WSClass): |
Member
There was a problem hiding this comment.
I'm not sure why is this necessary.
| ) | ||
| raise ite from norfdb | ||
|
|
||
| @subscribe('message.filter.student', 'l') |
Member
There was a problem hiding this comment.
This should not be part of this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a room message. This allows a message to reach every client in … …
…a room.
i.e.
{'type': 'message.filter.room(roomID)',
'content': [...] }