Skip to content

Conversation

@quentin-st
Copy link
Contributor

No description provided.

@PeterShaggyNoble PeterShaggyNoble merged commit d0a85d5 into Templarian:master Aug 22, 2018
@PeterShaggyNoble
Copy link
Collaborator

Thanks for taking this and running with it, @chteuchteu 😃 Definitely better than I could have managed.

I'd still like to see a standalone version for those that don't use NPM, though.

@quentin-st
Copy link
Contributor Author

quentin-st commented Aug 22, 2018

@PeterShaggyNoble The pleasure is mine! :-)

In order to avoid requiring npm/yarn, we'd have to publish MaterialDesign-SVG as composer package.
@Templarian : it's quite simple actually, all you have to do is to add a composer.json file in the project root dir, and publish it on packagist (https://packagist.org/).

Once done, GitHub will tell packagist when a new release is tagged and voilà!

This would allow us to skip the "withIconsPath" step:

Mdi::withIconsPath(__DIR__.'/../../../node_modules/@mdi/svg/svg/');

since we already know the vendor/ (composer's node_modules) relative path.

@Templarian : do you want me to open a new PR with the composer.json file? We'd have to create an account for MDI on packagist.

@quentin-st quentin-st deleted the feature-documentation-php branch August 22, 2018 13:19
@Templarian
Copy link
Owner

@chteuchteu Yea, we'll need to do that I suppose. Lets shoot to get this setup this weekend.

@quentin-st
Copy link
Contributor Author

Nice! :)

@quentin-st
Copy link
Contributor Author

@Templarian : I opened a PR with a shiny composer.json: Templarian/MaterialDesign-SVG#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants