Merged
Conversation
MengshiZhang
approved these changes
Jul 10, 2025
Dokujaa
reviewed
Jul 17, 2025
| try: | ||
| credentials = service_account.Credentials.from_service_account_info(self.cred_json, scopes=["https://www.googleapis.com/auth/cloud-platform"]) | ||
|
|
||
| # refresh token - run in thread pool to avoid blocking |
Contributor
There was a problem hiding this comment.
Im wondering if we could optimize this logic. OAuth2 Token's generally last an hour, but we are refreshing the token every call. Instead could we store the token in Redis cache, and then check for cache miss/expiry and then refresh the token.
Implementation approach:
- Check Redis cache for existing valid token first
- If cache miss or expired, refresh token and cache it
- Use credentials.expiry to set proper TTL (with 5-10 min safety buffer)
- Cache key: f"vertex_token:{hash(service_account_json)}"
Could slightly help performance
Contributor
Author
There was a problem hiding this comment.
Good suggestion 👍. I have some questions regarding to it. Let's move the discussion to your PR: #15
wilsonccccc
reviewed
Jul 22, 2025
wilsonccccc
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.