Merged
Conversation
8091a22 to
c2270c4
Compare
wilsonccccc
reviewed
Sep 1, 2025
| String, nullable=True | ||
| ) # Allow custom base URLs for some providers | ||
| model_mapping = Column(JSON, nullable=True) # JSON dict for model name mappings | ||
| billable = Column(Boolean, nullable=False, default=False) |
Contributor
There was a problem hiding this comment.
Shall we add a "billable" annotation at the model level instead of the provider level?
Contributor
Author
There was a problem hiding this comment.
It's an open discussion. My current implementation is based on the assumption that the billing object is at "provider" level. You could have "free model" by setting the price to be zero.
155f8f8 to
2970ab1
Compare
wilsonccccc
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database & Models
Core Services
API Integration
Webhook Infrastructure
Request Flow