Skip to content

Conversation

@Cervator
Copy link
Member

@Cervator Cervator commented Jul 4, 2020

IMPORTANT EDIT: This should be redone considering #10 - shouldn't merge into master. But it is a draft anyway so when I get back to it I can close and redo. I've more or less forgotten what this goes with anyway 😞

WIP / POC

Goal is expanding what a distro can contain, as well as their meanings. Yet at the same time shrink Omega a tad to shed older / broken modules

Edit: Since the diff doesn't show well which Omega modules were removed they are:

  • ChrisVolume2OST - lacks prefabs to hook up the music, so no current way to play the pieces. Easy enough to add at some point then we can add it back, but right now it does nothing and Vol1 is pretty solid on its own anyway
  • CopperAndBronze + WoodAndStone - part of TTA and fairly broken at this point. Some bits were salvaged into various content modules as part of the NeoTTA project
  • LegacyMusic - does have prefab hookups, but is very old and not part of any gameplays. Can likewise hook back up if there is interest sometime
  • NeoTTA - itself fairly broken, yet its content pieces can stay in. This way at least it gets bypassed as a gameplay template option, slimming that list down by one
  • QuestExamples - was renamed to a tutorial module, all of which were previously removed (there's a new "tutorials" line in this PR that should take over)
  • Sample - probably not very meaningful in the game dist, more of a thing for devs / new contributors to play with (there's a new "sample" line that includes it in a minimal setup)

Still working on the new stuff so this is just a draft for now

…ons for utility script rework, including two new module lines
@@ -0,0 +1,4 @@
# The Sample distro is not really a complete set of modules, but can be used as a minimal base developer workspace
# It will cause several additional modules to be fetched as binaries, but consists of overall less source
extraModules=CoreSampleGameplay,Sample
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoreSampleGameplay itself depends on other things - should these modules be listed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no - we're in a weird case here which might need a bit of reworking the logic. It again works as a good target for init (an example of something where you'd get jars fetched via Gradle when preparing your workspace) yet makes a poor definition for a zip, where yeah the lack of dependencies in the list here would lead to a broken zip. Odds are it would be better to either split apart the distro lists for init vs the zip packages or when using for zips then resolve all the dependencies and shove them into the zip as well

@@ -0,0 +1,3 @@
# The tutorials distro is full of our various developer tutorials
extraModules=CoreSampleGameplay,Sample,Tutorial*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to be able to build up the extra modules, e.g., take everything from sample and add tutorial*

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! The wildcard thing doesn't even work on its own yet, just thrown it in there as a reminder to look at doing that later since still POC :-)

A distro / listing extending another is another good example of a more rich feature for this system, although I'm not sure if it is worth the effort just yet. First goal would just be making a working zip at all again 👍

Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants