-
Notifications
You must be signed in to change notification settings - Fork 5
Trim Omega lineup a bit more, add experimental stuff #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ons for utility script rework, including two new module lines
| @@ -0,0 +1,4 @@ | |||
| # The Sample distro is not really a complete set of modules, but can be used as a minimal base developer workspace | |||
| # It will cause several additional modules to be fetched as binaries, but consists of overall less source | |||
| extraModules=CoreSampleGameplay,Sample | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CoreSampleGameplay itself depends on other things - should these modules be listed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and no - we're in a weird case here which might need a bit of reworking the logic. It again works as a good target for init (an example of something where you'd get jars fetched via Gradle when preparing your workspace) yet makes a poor definition for a zip, where yeah the lack of dependencies in the list here would lead to a broken zip. Odds are it would be better to either split apart the distro lists for init vs the zip packages or when using for zips then resolve all the dependencies and shove them into the zip as well
| @@ -0,0 +1,3 @@ | |||
| # The tutorials distro is full of our various developer tutorials | |||
| extraModules=CoreSampleGameplay,Sample,Tutorial* | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to be able to build up the extra modules, e.g., take everything from sample and add tutorial*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! The wildcard thing doesn't even work on its own yet, just thrown it in there as a reminder to look at doing that later since still POC :-)
A distro / listing extending another is another good example of a more rich feature for this system, although I'm not sure if it is worth the effort just yet. First goal would just be making a working zip at all again 👍
Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
IMPORTANT EDIT: This should be redone considering #10 - shouldn't merge into master. But it is a draft anyway so when I get back to it I can close and redo. I've more or less forgotten what this goes with anyway 😞
WIP / POC
Goal is expanding what a distro can contain, as well as their meanings. Yet at the same time shrink Omega a tad to shed older / broken modules
Edit: Since the diff doesn't show well which Omega modules were removed they are:
Still working on the new stuff so this is just a draft for now