-
Notifications
You must be signed in to change notification settings - Fork 0
[Feature] html 전체 대신 추출된 텍스트를 llm에 전달하도록 수정 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
59c4413
chore: html에서 마크다운으로의 변환을 위한 markdownify 의존성 추가
hjham0856 3067412
feat: 전달된 요청에 포함된 html을 요약 이전에 마크다운화
hjham0856 34d248e
refactor: 파라미터 이름을 text_html에서 tos_content로 변경
hjham0856 4ec78af
Merge pull request #21 from TermLens/feature/20-extract-text-from-html
hjham0856 d57dac1
feat: 전체 마크다운 파싱 결과를 출력하는 대신, 원본 html, 마크다운의 길이 및 감소율을 출력하도록 변경
hjham0856 355142c
Merge pull request #22 from TermLens/feature/20-extract-text-from-html
hjham0856 e41ee31
chore: 주석의 이전 변수명 text_html을 현재 사용하는 이름인 tos_content로 수정
hjham0856 3850d97
feat: 지나친 소수점 자리수를 제한
hjham0856 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| boto3 | ||
| boto3 | ||
| markdownify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential division by zero error if
event['body']is an empty string (though this is checked earlier at line 21, it still passes if body is whitespace-only). While the current validation prevents empty strings, consider the edge case whereoriginal_lengthcould be 0 after encoding.