Conversation
jrmi
suggested changes
Jan 20, 2020
LePetitTim
force-pushed
the
add_geocrud
branch
from
0347d33 to
c41cd21
Compare
jrmi
reviewed
May 27, 2020
jrmi
reviewed
May 27, 2020
jrmi
suggested changes
Jun 3, 2020
jrmi
approved these changes
Jun 8, 2020
submarcos
reviewed
Jun 8, 2020
src/project/settings/base.py
Outdated
| 'custom.dataloader', | ||
| 'django_json_widget', | ||
| 'reversion', | ||
| 'sorl.thumbnail', |
Member
There was a problem hiding this comment.
'mapbox_baselayer',
'django_json_widget',
'reversion',
'sorl.thumbnail',
are specific to geocrud, move to "if USE_TERRA_GEOCRUD"
submarcos
reviewed
Jun 8, 2020
| ## Uncoment these lines to enable and configure geocrud and add 'CRUD' above in enabled_modules | ||
| # TERRA_GEOCRUD = { | ||
| # 'EXTENT': [2, 40, 6, 50], | ||
| # 'MBGLRENDERER_URL': os.getenv('MBGLRENDERER_URL', 'http://mbglrenderer'), |
Member
There was a problem hiding this comment.
mbgl renderer is not added to the docker-compose stack ?
submarcos
reviewed
Jun 8, 2020
| # 'EXTENT': [2, 40, 6, 50], | ||
| # 'MBGLRENDERER_URL': os.getenv('MBGLRENDERER_URL', 'http://mbglrenderer'), | ||
| # "map": { | ||
| # "mapbox_access_token": "key_mapbox", |
Member
There was a problem hiding this comment.
not auto loaded from environment ?
submarcos
reviewed
Jun 8, 2020
| path('api/mapbox_baselayer/', include('mapbox_baselayer.urls')), | ||
| ] | ||
|
|
||
| if settings.DEBUG and False: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geocrud and Visu can't be together for now, identifier in geostore cannot be use for centroid with geocrud. If we want to use geocrud with visu we need to modify geostore and find a solution for not using the same identifier for the zone and it centroid. We could use extra geom for example or relations, added on geostore which is normally made for this case.