fix: show save button in VRL snippet form#17
Merged
TerrifiedBug merged 5 commits intomainfrom Mar 5, 2026
Merged
Conversation
Hide the snippet list when the creation form is open so the Cancel/Create buttons aren't clipped by the container overflow.
Use dev-<sha> version string in Docker agent builds to match the binary release format, enabling proper version detection in the fleet UI. The image still uses a single rolling 'dev' tag.
Greptile SummaryThis PR fixes a long-standing UX bug in the VRL snippet drawer where the The PR also bundles two legitimate improvements:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 35bbe81 |
When sinks retry failed events, eventsOut can exceed eventsIn, producing negative reduction values like -201%. Clamp to 0%.
When changing environment while viewing a pipeline editor or fleet detail page, redirect to the parent list page to avoid showing stale data from a different environment.
Apply max-h-64 and overflow-hidden only when browsing snippets. When the form is open, remove constraints so buttons are visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overflow-hiddencontainer was clipping the buttons below themax-h-64boundaryTest plan