Skip to content

fix: skip update-available check for dev versions#6

Merged
TerrifiedBug merged 1 commit intomainfrom
fix/skip-version-check-for-dev
Mar 4, 2026
Merged

fix: skip update-available check for dev versions#6
TerrifiedBug merged 1 commit intomainfrom
fix/skip-version-check-for-dev

Conversation

@TerrifiedBug
Copy link
Owner

@TerrifiedBug TerrifiedBug commented Mar 4, 2026

Summary

  • Agents running dev-tagged Docker images report "dev" as their version
  • isVersionOlder("dev", "0.1.2") produced undefined behavior due to NaN from "dev".split(".").map(Number)
  • Explicitly return false when either version is "dev" so the fleet page doesn't show "Update available" for dev agents

Test plan

  • Run dev-tagged agent image, verify no "Update available" badge on fleet page
  • Run released agent image older than latest, verify badge still appears

Agents running dev-tagged images report "dev" as their version.
isVersionOlder("dev", "0.1.2") produced undefined behavior due to
NaN from parsing. Explicitly return false when either version is "dev".
@github-actions github-actions bot added fix and removed fix labels Mar 4, 2026
@greptile-apps
Copy link

greptile-apps bot commented Mar 4, 2026

Greptile Summary

Fixes undefined behavior in version comparison when agents report "dev" as their version string. The isVersionOlder() function now explicitly returns false when either version is "dev", preventing NaN results from "dev".split(".").map(Number) and stopping spurious "Update available" badges from appearing on the fleet page for development builds.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Single-line fix that addresses a specific edge case with clear intent. The change is minimal, well-scoped, and prevents undefined behavior without affecting normal version comparisons. No breaking changes or side effects.
  • No files require special attention

Important Files Changed

Filename Overview
src/lib/version.ts Added early return for "dev" versions to prevent NaN from string-to-number conversion

Last reviewed commit: c042aa4

@TerrifiedBug TerrifiedBug merged commit 3c61da1 into main Mar 4, 2026
13 checks passed
@TerrifiedBug TerrifiedBug deleted the fix/skip-version-check-for-dev branch March 4, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant