Conversation
LabordePierre
left a comment
LabordePierre
left a comment
There was a problem hiding this comment.
Missing bugs and may be new usages to cover.
|
|
||
| layerB := geoViewManager createDomainObjectsLayer: #layerB. | ||
| geoViewManager addLayer: layerB. | ||
| self assert: layerB notNil. |
There was a problem hiding this comment.
place assertion before adding
|
|
||
| layerC := geoViewManager createDomainObjectsLayer: #layerC. | ||
| geoViewManager addLayer: layerC afterIndex: 1. | ||
| self assert: layerC notNil. |
There was a problem hiding this comment.
place assertion before adding
| GeoViewManagerImpl >> addLayer: aLayer afterIndex: anIndex [ | ||
|
|
||
| aLayer name ifNil: [ ^ nil ]. | ||
| self configureLayer: aLayer. |
There was a problem hiding this comment.
duplicated code with addLayer: method. addLayer: should call addLayer: afterIndex: (see AbstractGeoViewElement>>addLayer:)
| "when the shape haven't coordinates, that mean the shape is managed by a parent (i.e. a dComposite), return an offset if exists" | ||
| aDShape coordinates ifNil: [ ^ offset ]. | ||
| self processor ifNil: [ ^ nil ]. | ||
| self processor projection ifNil: [ ^ nil ]. |
There was a problem hiding this comment.
projection cannot be nil here, this is a bug to resolve. I cannot accept because this is dangerous.
|
|
||
| self layers do: [ :e | | ||
| e haveDomainObjects ifTrue: [ e updateObjects: anUserObjectList ] ] | ||
| self flag: 'TODO: Add a mutex for accessing layers collection'. |
There was a problem hiding this comment.
I cannot accept, this is a bug to resolve.
|
|
||
| | centerGeoPoint level tilesXY tilesXYBuffer findAtLeastOneTile realLevel| | ||
|
|
||
| self surfaceMap ifNil:[^self]. |
There was a problem hiding this comment.
same problem : this is a bug to resolve. but I know this class is dirty, but maybe previous problems was related to the same reason.
|
|
||
| self layers do: [ :e | | ||
| e haveDomainObjects ifTrue: [ e updateObjects: anUserObjectList ] ] | ||
| self flag: 'TODO: Add a mutex for accessing layers collection'. |
There was a problem hiding this comment.
I cannot accept, this is a bug to resolve.
|
|
||
| | centerGeoPoint level tilesXY tilesXYBuffer findAtLeastOneTile realLevel| | ||
|
|
||
| self surfaceMap ifNil:[^self]. |
There was a problem hiding this comment.
same problem : this is a bug to resolve. but I know this class is dirty, but maybe previous problems was related to the same reason.
|
@LANDAISB is this Pull Request again valid? |
|
Don't know yet, I want to check if mutex on layers fix all these problems. I have to test it on projects |
|
Ok, stay "pending" |
3 participants
No description provided.