-
-
Notifications
You must be signed in to change notification settings - Fork 277
Reflect-cpp traits #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Reflect-cpp traits #392
Conversation
Hi and thanks for extending jwt-cpp. |
@Thalhammer Added tests, using FetchContent if reflectcpp is not found |
@Thalhammer I've added everything needed for CI, including
On my fork, the CI runs successfully for everything assosciated with the new reflect-cpp trait. Unfortunately, one CI item seems to fail (JWT CI / coverage (pull_request)) but I see that is broken on main in the repo and that you're in the process of fixing it. Please let me know if you'd like any further modifications. |
I noticed the lint ci is missing the new json library, i am okay with it missing. You might want to update the readme to share your excellent work! |
Per your comments, I have
Could you clarify what you mean by updating the readme? I don't see anything about any of the other traits or contributors in the |
Yes that section used to be in the readme itself before it got too large 😅 |
Added reflect-cpp to docs/traits.md. Any outstanding items before we can merge this? |
This PR adds traits for the reflect-cpp json library