fix(materials): Fix setColor and setOpacity #148
+42
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds explicit property tracking for
setColorandsetOpacityhighlight methods to fix issues where:THREE.Colorinstances insetColorsetColorthensetOpacity) was overwriting previous properties instead of preserving themChanges:
_explicitPropsarray toMaterialDefinitionto track which properties were explicitly setTHREE.ColorinsetColorwith proper colorspacegetNewHighFromPastto merge explicit properties correctly when combining highlightsMaterialManagerserialization to only apply explicitly set highlight propertiesThis ensures that calling
setColorfollowed bysetOpacity(or vice versa) preserves both properties correctly.What is the purpose of this pull request?