Added support for chatops using prettier and github actions by tushar5526 · Pull Request #37 · The-Codesis/simple-static-website

tushar5526 · 2020-06-15T19:16:47Z

Closes #35
This PR adds a workflow which uses prettier to auto-format the files with js css vue jsx files
Steps Followed :

Initialized npm in the repo
Added .gitignore to ignore node-modules
Added the workflow in prettier.yml inside .github/workflows
Formatting will happen only when we use /style in conversation of a PR

tushar5526 · 2020-06-16T06:02:38Z

I saw some blogs, where we can put more features in this. Like putting a reaction ( emoji ) after jobs complete and admin-level rights to call the jobs.
Should I try working on this ? @rahul799 @und3fined-v01d

rahul799 · 2020-06-16T06:04:31Z

Ya... You can... I will suggest that can you open a issue for that, maybe others who are interested can also work on it.

rahul799 · 2020-06-16T18:42:57Z

+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+      - uses: r-lib/actions/setup-r@master
+      - name: Install
+        run: yarn run prettier --write '**/*.{css,js,vue}'


right now we won't have .vue type file. So you can remove it. Also, you must add .html.

rahul799 · 2020-06-16T18:44:27Z

+      - id: file_changes
+        uses: trilom/file-changes-action@v1.2.3
+      - name: testing
+        run: echo '${{ steps.file_changes.outputs.files_modified}}'


I won't think we need this as you are running prettier in all the files.

ok, I will look into this step.
Thanks for pointing out

rahul799

Please make the changes.

rahul799 · 2020-06-16T18:47:33Z

+{
+  "name": "simple-static-website",
+  "version": "1.0.0",
+  "description": "This repository will help beginners who have just completed the Git course &amp; want to apply their theoretical knowledge.",
+  "main": "index.js",
+  "dependencies": {
+    "prettier": "2.0.5"
+  },
+  "devDependencies": {},
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/tushar5526/simple-static-website.git"
+  },
+  "keywords": [],
+  "author": "",
+  "license": "ISC",
+  "bugs": {
+    "url": "https://github.com/tushar5526/simple-static-website/issues"
+  },
+  "homepage": "https://github.com/tushar5526/simple-static-website#readme"
+}


do we need this file?

I am not well versed with node.js, but prettier was giving up errors. So I installed it before hand, but I can try a work around in which I install prettier at run time and add files by their extensions, instead of adding all files using git add .

rahul799 · 2020-06-16T18:47:52Z

+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+
+prettier@2.0.5:
+  version "2.0.5"
+  resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.0.5.tgz#d6d56282455243f2f92cc1716692c08aa31522d4"
+  integrity sha512-7PtVymN48hGcO4fGjybyBSIWDsLU4H4XlvOHfq91pz9kkGlonzwTfYkaIEwiRg/dAJF9YlbsduBAgtYLi+8cFg==


same goes for this

tushar5526 · 2020-06-17T16:51:42Z

take a look now @rahul799 , I am now installing yarn at run time

Working demo : link

PS: there is one HTML file that is "faulty" in the repo, prettier is showing some errors on it link

Soham also asked to include jsx files but we can make it as an issue ?

Formatting will happen only when we use /style in conversation of a PR Currently, it formats the files with .js .html and .css extensions

rahul799 · 2020-06-18T08:42:59Z

right now we won't have JSX files in the repo. So it will have no significance.

tushar5526 · 2020-06-18T10:27:41Z

Any other changes @rahul799 ?

rahul799 · 2020-06-18T10:40:30Z

https://github.com/tushar5526/simpleWebsiteSandbox/pull/9#issuecomment-645875108 please have a look.

tushar5526 · 2020-06-18T10:48:30Z

hey @rahul799 index.html has some errors see this That's why I had excluded .html files earlier to test if prettier is working fine or not

See the Run Yarn section in the above link
Line 221 in index.html has closing tag missing

rahul799 · 2020-06-18T10:51:14Z

It will be good if you debug that.
Hint : you just need to delete the extra h2 tag, as shown in the error log.

rahul799 · 2020-06-18T10:56:45Z

ok let us leave it for now. I think we are good to go.

tushar5526 · 2020-06-18T11:00:14Z

I have changed it in sandbox website I have, and made an issue for someone else to fix it here.`
span tag is missing in index.html

tushar5526 · 2020-06-18T11:16:19Z

Job built successfully link

rahul799 · 2020-06-18T11:17:59Z

Good job tushar. Keep it up.

…

On Thu, 18 Jun, 2020, 4:46 pm Tushar, ***@***.***> wrote: Job built successfully link <https://github.com/tushar5526/simpleWebsiteSandbox/runs/784058068?check_suite_focus=true> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJ43Q2X5OZ5PQEQAREGWLDLRXHZRBANCNFSM4N6PVAYA> .

tushar5526 · 2020-06-18T19:43:32Z

Looking for next tasks :P @rahul799

rahul799 · 2020-06-20T04:14:57Z

For now, we are good to merge it.

tushar5526 · 2020-06-22T14:58:14Z

I am thinking to work on #38 , should I add commits in this PR or wait for it to merge ? @rahul799 @und3fined-v01d

sovoid · 2020-06-22T15:36:53Z

@tushar5526. I think its better to wait till this gets merged. Especially since we might transition the entire code here as a config to hydrabot. Wait for the PR to be merged and then we can create a separate for the remainder

tushar5526 · 2020-06-22T15:39:14Z

Sure @und3fined-v01d

rahul799 · 2020-06-26T08:35:17Z

@und3fined-v01d so are you going to merge it?

tushar5526 mentioned this pull request Jun 16, 2020

Add more features in the GitHub Bot, that uses prettier to format files in a PR #38

Open

rahul799 reviewed Jun 16, 2020

View reviewed changes

rahul799 requested changes Jun 16, 2020

View reviewed changes

Added support for chatops using prettier and github actions

9ec681d

Formatting will happen only when we use /style in conversation of a PR Currently, it formats the files with .js .html and .css extensions

rahul799 approved these changes Jun 18, 2020

View reviewed changes

rahul799 requested a review from sovoid June 18, 2020 10:57

Uh oh!

Conversation

tushar5526 commented Jun 15, 2020

Uh oh!

tushar5526 commented Jun 16, 2020

Uh oh!

rahul799 commented Jun 16, 2020

Uh oh!

rahul799 Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

tushar5526 Jun 17, 2020

Choose a reason for hiding this comment

Uh oh!

rahul799 Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

tushar5526 Jun 17, 2020

Choose a reason for hiding this comment

Uh oh!

rahul799 left a comment

Choose a reason for hiding this comment

Uh oh!

rahul799 Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

tushar5526 Jun 17, 2020

Choose a reason for hiding this comment

Uh oh!

rahul799 Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

tushar5526 commented Jun 17, 2020

Uh oh!

rahul799 commented Jun 18, 2020

Uh oh!

tushar5526 commented Jun 18, 2020

Uh oh!

rahul799 commented Jun 18, 2020

Uh oh!

tushar5526 commented Jun 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rahul799 commented Jun 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rahul799 commented Jun 18, 2020

Uh oh!

tushar5526 commented Jun 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tushar5526 commented Jun 18, 2020

Uh oh!

rahul799 commented Jun 18, 2020 via email

Uh oh!

tushar5526 commented Jun 18, 2020

Uh oh!

rahul799 commented Jun 20, 2020

Uh oh!

tushar5526 commented Jun 22, 2020

Uh oh!

sovoid commented Jun 22, 2020

Uh oh!

tushar5526 commented Jun 22, 2020

Uh oh!

rahul799 commented Jun 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tushar5526 commented Jun 18, 2020 •

edited

Loading

rahul799 commented Jun 18, 2020 •

edited

Loading

tushar5526 commented Jun 18, 2020 •

edited

Loading