fix(gerrit): explicitly set git provider in server startup#2317
Open
fix(gerrit): explicitly set git provider in server startup#2317
Conversation
The Gerrit server's start() function did not set CONFIG.GIT_PROVIDER to "gerrit", relying instead on implicit URL format detection to determine the provider. This could cause the wrong provider to be selected. Other servers (bitbucket_app, gitlab_webhook) explicitly set their git provider during startup. This commit adds the same explicit configuration to the Gerrit server for consistency and correctness.
Contributor
Review Summary by QodoSet explicit git provider for Gerrit server startup
WalkthroughsDescription• Explicitly set git provider to "gerrit" in server startup • Aligns Gerrit server with pattern used by other servers • Prevents reliance on implicit URL format detection Diagramflowchart LR
A["Gerrit Server start()"] -->|"set CONFIG.GIT_PROVIDER"| B["Provider = gerrit"]
B -->|"explicit configuration"| C["Consistent with other servers"]
File Changes1. pr_agent/servers/gerrit_server.py
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start()function was missingget_settings().set("CONFIG.GIT_PROVIDER", "gerrit"), causing it to rely on implicit URL format detection instead of explicit configurationbitbucket_app.py,gitlab_webhook.py) already set their provider explicitly at startup -- this aligns the Gerrit server with the same patterngerrit_server.py:start()to set the provider before the app startsTest plan
get_settings().config.git_providerreturns"gerrit"afterstart()is called🤖 Generated with Claude Code