Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dkchiem
force-pushed
the
change-send-transactions
branch
from
b3fb03a to
48c2e5b
Compare
Member
|
We ended up not using tuples, so the overloaded function is not needed |
Member
|
@Samuel-Martineau Could you take a look at this? We have a SendOptions struct for the communication with the wallet through deeplinking but we also have a slightly different SendTransactionConfiguration struct for RPC sendTransaction |
Samuel-Martineau
force-pushed
the
main
branch
from
fbc0739 to
081cb56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exposed transactionOptions struct for sendTransaction, overloaded function to automatically spread the struct into a tuple (sendTransaction.swift)