Skip to content

Conversation

ananya-research
Copy link
Contributor

No description provided.

@ananya-research ananya-research marked this pull request as ready for review October 1, 2025 02:58
@DenizAltunkapan DenizAltunkapan force-pushed the update-directory branch 16 times, most recently from 7fa68e1 to c545617 Compare October 5, 2025 18:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.77%. Comparing base (9484c7e) to head (3c55907).
⚠️ Report is 1 commits behind head on update-directory.

Files with missing lines Patch % Lines
.../main/java/com/thealgorithms/graph/ZeroOneBfs.java 76.66% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             update-directory    #6561      +/-   ##
======================================================
+ Coverage               75.75%   75.77%   +0.01%     
- Complexity               5772     5782      +10     
======================================================
  Files                     703      704       +1     
  Lines                   19777    19807      +30     
  Branches                 3832     3840       +8     
======================================================
+ Hits                    14982    15008      +26     
- Misses                   4215     4217       +2     
- Partials                  580      582       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DenizAltunkapan DenizAltunkapan force-pushed the update-directory branch 2 times, most recently from 5f1b83c to 09a07e2 Compare October 6, 2025 18:23
@DenizAltunkapan DenizAltunkapan force-pushed the update-directory branch 4 times, most recently from 2be7ace to a5b37b7 Compare October 8, 2025 06:43
Copy link
Member

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good and correctly follows the 0–1 BFS algorithm. However, note that although BreadthFirstSearch and DepthFirstSearch are in com.thealgorithms.searches, this class logically belongs in com.thealgorithms.graph because it solves a shortest-path problem rather than a graph traversal. Its placement in the graph package is therefore appropriate and consistent with other shortest-path algorithms such as Dijkstra or Bellman–Ford.

@DenizAltunkapan DenizAltunkapan merged commit 373dceb into TheAlgorithms:update-directory Oct 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants