Improve capitalize(): add Unicode support and handle leading spaces #13967
+15
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This Pull Request improves the existing capitalize() function by making it more robust and user-friendly.
The function now properly capitalises the first alphabetical character, handles Unicode letters, and preserves leading spaces — all while maintaining backward compatibility.
Changes Introduced:
Added logic to locate the first alphabetic character (not just index 0).
Added support for Unicode characters such as ñ, ö, ç, etc.
Preserved the original structure of the string, including leading spaces.
Improved and expanded doctest examples for better coverage.
I'd like for you to ensure safe handling of empty strings and strings without alphabetic characters.