Merged
Conversation
dportnoy15
approved these changes
Feb 24, 2026
Contributor
dportnoy15
left a comment
dportnoy15
left a comment
There was a problem hiding this comment.
Looks good! Just some minor suggestions about doing early returns.
| if (composite.getParent() instanceof ManipulationHandle3D) { | ||
| return (ManipulationHandle3D) composite.getParent(); | ||
| ProgramImp program = scene.getImplementation().getProgram(); | ||
| if (program != null) { |
Contributor
There was a problem hiding this comment.
Perhaps instead do this instead, if you're ok with early returns, so the main part of the code doesn't need to be indented:
if (program == null) {
return;
}
| this.dragAdapter.makeCameraActive(camera); | ||
| this.dragAdapter.setAnimator(this.scene.getProgram().getAnimator()); | ||
| ProgramImp program = scene.getProgram(); | ||
| if (program != null) { |
Contributor
There was a problem hiding this comment.
Ditto about early returns
| */ | ||
| public class SceneImp extends EntityImp { | ||
| private static final Transformable createDirectionalLightTransformable(DirectionalLight sgDirectionalLight, Angle yaw, Angle pitch, float brightness) { | ||
| private static Transformable createDirectionalLightTransformable(DirectionalLight sgDirectionalLight, Angle yaw, Angle pitch, float brightness) { |
Contributor
There was a problem hiding this comment.
Was the removal of final here intentional? Just wondering since I don't see the method being overridden anywhere in the PR.
Contributor
Author
There was a problem hiding this comment.
Yes. It is static, so final adds nothing.
| } | ||
|
|
||
| //todo | ||
| // private static class Capsule { |
Contributor
There was a problem hiding this comment.
Oh, no! My favorite class is going away!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Belt and suspenders fixes for null program in sceneImp. Plus some code cleanup