-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/4.0.0 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature/4.0.0 #26
Conversation
3e6bc24 to
1ca130d
Compare
1ca130d to
4d4c867
Compare
…imming, warnings.
0d29af4 to
cf6a1a3
Compare
| "; | ||
|
|
||
| AddSource(context, source, "EntityFrameworkDomainModelConfigurationExtensions", $"{Constants.DomainModelingNamespace}.EntityFramework"); | ||
| AddSource(context, source, "EntityFrameworkDomainModelConfigurationExtensions", $"Architect.DomainModeling.EntityFramework"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error CS0016: Could not write to output file
I think the path is to long on my machine
I checked out to 'C:\Development\GitHub\Architect.DomainModeling'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JoergHoffmannatGitHub, this works fine for me if I imitate your approach:
D:\Development\GitHub>git clone https://github.com/TheArchitectDev/Architect.DomainModeling.git
D:\Development\GitHub>cd Architect.DomainModeling
D:\Development\GitHub\Architect.DomainModeling>dotnet build
What is the reason you are trying to build from source, particularly in the context of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Using 'dotnet build' works fine.
Personally, I prefer building with Visual Studio Community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious that the results differ. I get the same result (success) in VS.
Do you have the solution file under C:\Development\GitHub\Architect.DomainModeling or C:\Development\GitHub\Architect.DomainModeling\Architect.DomainModeling?
What are you trying to achieve by building, and what is the relation to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solution is located at C:\Development\GitHub\Architect.DomainModeling.
I am playing around with some ideas on how to use the attributes for defining a domain model to understand the generated code and how the entity, value object, and others work together.
The easiest way was to generate some classes in the sample project.
Ultimately, I plan to use the Nuget package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. It's unclear to me why you're seeing the path length issue and I'm not, for the same IDE and local path.
For what it's worth, you might be able to do what you're trying to do with the NuGet package as well. Or you could use a shorter local path as an annoying workaround. 😛
cf6a1a3 to
416c79b
Compare
…and (.NET 10+) extension members. Prepared outcommented precompiler directives for a .NET 10 patch upgrade, to reduce assembly bloat then. Also corrected how formattable/parsable is determined based on wrapped types. Also fixed a few bugs.
…y. (ArraySegment, the other common collection struct, has implicit conversions from arrays, which mess with nullability constraints.)
Also cleaned up the way in which lines not being source generated are outcommented. Also improved source generator performance. Also prevented transient issues when reporting warnings on wrapper types.
…d on implicit conversion.
…nd/or use a custom base class.
This reverts commit 8d46796.
…o attribute, and attribute inheritance.
416c79b to
402bead
Compare
Generic JSON serializers instead of generated.
Removed #if NET7/8 conditionals, now that 8 is the minimum version.
Upgraded LangVersion and handled compiler suggestions.
Suppressions and summary corrections.
Implemented formatting/parsing via default interface implementations and (.NET 10+) extension members.
Prepared outcommented precompiler directives for a .NET 10 patch upgrade, to reduce assembly bloat then.
Also corrected how formattable/parsable is determined based on wrapped types.
Also fixed a few bugs.
Generator performance and cleanup.
Added serialization to/from deepest underlying type (recursive).
Also cleaned up the way in which lines not being source generated are outcommented.
Also improved source generator performance.
Also prevented transient issues when reporting warnings on wrapper types.
Added wrapper EF collations, collation checks, and provider comparers.