Fix conversion of degree to radian angle#100
Open
yousefkazemy1 wants to merge 2 commits intoTheChance101:masterfrom
Open
Fix conversion of degree to radian angle#100yousefkazemy1 wants to merge 2 commits intoTheChance101:masterfrom
yousefkazemy1 wants to merge 2 commits intoTheChance101:masterfrom
Conversation
Collaborator
|
Thx for your help we will review it as soon as we can |
kafri8889
approved these changes
Jan 30, 2024
AndrewAboalhana
requested review from
AndrewAboalhana,
amnah44 and
yassenRamadan1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed this problem
#99
Problem:
Instead of using the correct PI in the calculation, (22/7) is used for PI. This causes the problem because (22/7) is not the same as standard PI(Koltin PI).
I also fixed this issue:
#102
Problem:
When data value is zero, the app crashes because of creating Unspecified value