Skip to content

Fix/fth 200 UI issues in faith#1215

Open
BassantM wants to merge 18 commits intodevelopfrom
fix/FTH-200-ui-issues-in-faith
Open

Fix/fth 200 UI issues in faith#1215
BassantM wants to merge 18 commits intodevelopfrom
fix/FTH-200-ui-issues-in-faith

Conversation

@BassantM
Copy link
Collaborator

@BassantM BassantM commented Nov 30, 2025

Removes redundant padding from the ReciterItem and moves the horizontal padding to the parent screens (ReciterSelectionScreen, SurahRecitersScreen, DownloadedRecitersScreen) for better layout consistency.
Adds a background color and clip shape to the ReciterItem within the swipeable card on the DownloadedRecitersScreen.
Removes the unnecessary fillMaxWidth and padding modifiers from the SearchEmptyState composable in the ReciterSelectionScreen and DownloadedRecitersScreen.
The SearchEmptyState now internally uses fillMaxSize to handle its own layout, simplifying the call sites.
Add reciterArabicName to DownlodedSur domain model and corresponding UI states.
Implement localizedName() extension function to provide the correct reciter name based on the app's language (Arabic or English).
Update the data layer, including the repository and mappers, to fetch and handle Arabic reciter names.
Integrate the localization logic into various UI components, including the Quran player, downloaded surah list, and downloaded reciters screen, to display the appropriate name.

Translate the tilawahType from English to Arabic within the ReciterDto.toReciter mapper based on the application's language.

  • Add a private handleTilawah function to perform the translation.
  • The function translates "Mujawwad" to "مُجود" and defaults other types to "مُرتل" for Arabic.
image image image

@BassantM BassantM self-assigned this Nov 30, 2025
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...t/thechance/mena/faith/data/mapper/TilwahMapper.kt 58.33% 3 Missing and 2 partials ⚠️
.../mena/faith/data/repository/QuranRepositoryImpl.kt 37.50% 5 Missing ⚠️
...mena/faith/presentation/feature/main/MainMapper.kt 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

)
id = id,
name = name,
nameAr = name,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s a bad idea to use the same value for name and nameAr, so what’s the difference between them?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A domain should have only one name, how can u solve this issue in mapping

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API call returns a List<RecitersRequest>, and since RecitersRequest contains both name and arabicName, it can be mapped directly to ReciterDto without issues. This makes the mapper from Reciter to ReciterDto unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants