Open
Conversation
- Delete `item_actor_home.xml`, `item_actor_search.xml`, and `item_actor_see_all.xml`.
- Modify `item_actor.xml`:
- Change root from `<layout>` to `<androidx.constraintlayout.widget.ConstraintLayout>`.
- Add a `FrameLayout` (`@+id/image_container`) to hold actor image and placeholder icons.
- Add `ImageView` for "no image" icon (`@+id/noImg_icon`) using `ic_no_actor_img.xml`.
- Add `ImageView` for placeholder icon (`@+id/placeholder_icon`) using `ic_user`.
- Make `ShapeableImageView` (`@+id/image_actor`) initially gone.
- Remove data binding variables `listener` and `item`.
- Update `TextView` (`@+id/text_actor_name`) to use `@string/actor_name`.
- Add new drawable `ic_no_actor_img.xml`.
- Add new string resources: `actor_placeholder`, `no_img`, `actor_name` in `values/strings.xml` and `values-night/strings.xml`.
- Update `ActorsAdapter.kt`:
- Modify constructor to accept `layoutID` as a parameter.
- Update `ActorsFragment.kt`:
- Pass `R.layout.item_actor` as `layoutID` to `ActorsAdapter`.
- Update `ActorSearchAdapter.kt`:
- Change `layoutID` to `R.layout.item_actor`.
- Update `HomeAdapter.kt`:
- Change `ActorAdapter` layout from `R.layout.item_actor_home` to `R.layout.item_actor`.
# Conflicts: # app/src/main/res/layout/item_actor.xml # app/src/main/res/layout/item_actor_home.xml # app/src/main/res/layout/item_actor_search.xml
Add new bottom navigation bar with dark theme support
Add custom cursor drawables and layout
feature/tabs
Reafctor/txt
refactor/profile-screen-ui
Removes unnecessary comments and streamlines tab selection in `MainActivity`.
Add Collection Item Layout
This layout defines a UI component for displaying informational messages with a title, caption, and two buttons.
refactor/home-secreen-ui
# Conflicts: # app/src/main/java/com/karrar/movieapp/utilities/BindingAdapter.kt # app/src/main/res/layout/error_tv_show_details.xml
add header item rating
…ng and visual consistency
…tyling and consistency
…ckages, and related UI states for improved clarity and consistency
…gation Refactor list details to collection details, update profile navigation
refactor/nav-bar-ui
component/rating-stars
add ar strings
…ails # Conflicts: # app/src/main/res/values/strings.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the screen of details for both movie and tvshow
