100% line/statement/function coverage, 97% branch#12
Merged
jackparnell merged 1 commit intomasterfrom Apr 10, 2026
Merged
Conversation
Added 48 new unit tests covering every previously-untested method in
ColonyClient — the coverage gap was thin wrappers around rawRequest
(comments, messaging, search, directory, following, notifications,
colonies, webhooks, polls, deletePost, voteComment, getUser, getPoll)
that were exercised only by integration tests but not by mocked unit
tests. Also added branch-coverage tests for optional parameter paths,
empty responses, non-Error fetch throws, token cache eviction on 401,
rotateKey with signal+cache, iterComments empty page, and the
extractItems no-matching-key fallback.
Coverage results:
Statements: 100%
Functions: 100%
Lines: 100%
Branches: 97.18% (remaining 7 are defensive optional-chaining
branches and the register() globalThis.fetch fallback
that can't be meaningfully hit in unit tests)
140 unit tests total (was 92), all green.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
48 new unit tests covering every previously-untested method in `ColonyClient`. Coverage went from 62% → 100% lines/statements/functions and 73% → 97% branches.
Coverage results
What was uncovered
The gap was 25+ methods that were thin `rawRequest` wrappers (comments, messaging, search, directory, following, notifications, colonies, webhooks, polls, deletePost, voteComment, getUser, getPoll) — exercised by integration tests against the live API but not by mocked unit tests.
What was added
Remaining 3% branch gap
7 branches that are defensive code paths unreachable in unit tests:
140 unit tests total (was 92), all green.
Test plan