Camera cooling settings#1171
Conversation
|
@TrungNguyenDuc - I assume your system inspired this PR. Could you please confirm that it is functioning as you hoped? |
There was a problem hiding this comment.
Pull request overview
This PR adds automatic camera temperature monitoring for 10 seconds after camera cooling is enabled, with a manual refresh button available afterward. When multiple microscopes share the same physical camera, switching between them preserves and displays the correct cooling state.
Changes:
- Modified command routing to support microscope-specific camera cooling commands
- Added threaded temperature refresh mechanism that runs for 10 seconds after cooling is enabled
- Implemented camera state synchronization across microscopes sharing the same physical camera
- Enhanced synthetic camera to simulate realistic temperature changes during cooling
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| src/navigate/model/model.py | Routes camera cooling commands to specific microscope instances instead of active microscope |
| src/navigate/model/microscope.py | Implements temperature refresh thread with event-based control and new command handlers |
| src/navigate/model/devices/camera/synthetic.py | Adds temperature simulation that decreases when cooling is enabled |
| src/navigate/model/devices/camera/hamamatsu.py | Retrieves and stores initial cooling state from hardware during initialization |
| src/navigate/controller/sub_controllers/camera_settings.py | Manages UI state for cooling controls and synchronizes cooling state across microscopes |
| src/navigate/controller/controller.py | Updates command routing to handle new camera cooling commands |
| src/navigate/controller/configuration_controller.py | Adds method to determine if microscopes use the same physical camera |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@annie-xd-wang - A few of the copilot recommendations seem decent. Maybe we should adopt a few of these? |
|
Yes. The turn-on and turn-off functions for the Hamamatsu camera cooling
with liquid work. The reading temperature camera temperature function also
works.
*Trung Duc Nguyen (Ted Nguyen)*
Department of Biomedical Engineering
The University of Texas at Austin
107 W Dean Keeton St. Stop C0800
Austin, TX 78712
Web: http://research.engr.utexas.edu/yeh
<http://research.engr.utexas.edu/yeh>
――――――――――――――――――――
…On Thu, Jan 29, 2026 at 6:03 AM Kevin M. Dean ***@***.***> wrote:
*AdvancedImagingUTSW* left a comment (TheDeanLab/navigate#1171)
<#1171 (comment)>
@TrungNguyenDuc <https://github.com/TrungNguyenDuc> - I assume your
system inspired this PR. Could you please confirm that it is functioning as
you hoped?
—
Reply to this email directly, view it on GitHub
<#1171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC4AH3TQ5T2UEGSCODWVCRT4JHZJTAVCNFSM6AAAAACTHIGS26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMJXGIZDGMJSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1171 +/- ##
===========================================
- Coverage 52.66% 52.49% -0.17%
===========================================
Files 197 197
Lines 23885 23968 +83
===========================================
+ Hits 12580 12583 +3
- Misses 11305 11385 +80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
This PR adds automatic camera temperature refreshing for 10 seconds after camera cooling is enabled. Users can also manually refresh the temperature by clicking the Refresh button afterward.
When the same physical camera is shared across multiple microscopes, switching microscopes will preserve the cooling settings and display the current state correctly.