Add stage position caching and safe config access #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use safe dict .get lookups in GUI controllers to avoid KeyError when nested settings are missing. Introduce Microscope.cache_stage_positions and set_stage_position_cache_policy(image_mode) to enable caching of stage positions for z-stack/customized modes, reducing repeated config lookups and per-step overhead. Wire policy application in Model during initialization and update tests to call the policy setter and assert caching behavior. Also add AGENTS.md with project notes and developer workflows.
Collaborator
Author
|
@conorhughmcfadden - Could you test this branch and see if you can now achieve something closer to 100 Hz? |
Mark test_single_acquisition as flaky with reruns to reduce CI flakes; handle camera batch responses that return lists by counting frames from list lengths (rename variables to n_frames_expected and n_framed_received). Move initial image recv handling, add a max_iters safety counter to avoid infinite loops, and update the final assertion to compare counted frames to expected. Also apply a minor formatting fix to the multiposition test input list spacing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1172 +/- ##
===========================================
- Coverage 52.51% 52.51% -0.01%
===========================================
Files 197 197
Lines 23968 23976 +8
===========================================
+ Hits 12586 12590 +4
- Misses 11382 11386 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
annie-xd-wang
approved these changes
Feb 3, 2026
TrungNguyenDuc
pushed a commit
to TrungNguyenDuc/navigate
that referenced
this pull request
Feb 6, 2026
* Add stage position caching and safe config access Use safe dict .get lookups in GUI controllers to avoid KeyError when nested settings are missing. Introduce Microscope.cache_stage_positions and set_stage_position_cache_policy(image_mode) to enable caching of stage positions for z-stack/customized modes, reducing repeated config lookups and per-step overhead. Wire policy application in Model during initialization and update tests to call the policy setter and assert caching behavior. Also add AGENTS.md with project notes and developer workflows. * Update microscope.py * Improve robustness of test_single_acquisition Mark test_single_acquisition as flaky with reruns to reduce CI flakes; handle camera batch responses that return lists by counting frames from list lengths (rename variables to n_frames_expected and n_framed_received). Move initial image recv handling, add a max_iters safety counter to avoid infinite loops, and update the final assertion to compare counted frames to expected. Also apply a minor formatting fix to the multiposition test input list spacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use safe dict .get lookups in GUI controllers to avoid KeyError when nested settings are missing. Introduce Microscope.cache_stage_positions and set_stage_position_cache_policy(image_mode) to enable caching of stage positions for z-stack/customized modes, reducing repeated config lookups and per-step overhead. Wire policy application in Model during initialization and update tests to call the policy setter and assert caching behavior. Also add AGENTS.md with project notes and developer workflows.